Summary: | Make a bunch of DocumentLoader functions private | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nate Chapin <japhet> | ||||||
Component: | WebCore Misc. | Assignee: | Nate Chapin <japhet> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, ap, koivisto, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Nate Chapin
2013-03-29 13:22:11 PDT
Created attachment 195787 [details]
patch
Comment on attachment 195787 [details] patch Rejecting attachment 195787 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 195787, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 14075 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 55>At revision 14075. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://webkit-commit-queue.appspot.com/results/17300493 Comment on attachment 195787 [details]
patch
Looks like you're missing a ChangeLog.
(In reply to comment #3) > (From update of attachment 195787 [details]) > Looks like you're missing a ChangeLog. Yeah, I tried to get clever with diffing and failed. Re-uploading now. Created attachment 195981 [details]
Patch for landing
Comment on attachment 195981 [details] Patch for landing Clearing flags on attachment: 195981 Committed r147336: <http://trac.webkit.org/changeset/147336> All reviewed patches have been landed. Closing bug. |