| Summary: | [Chromium] IndexedDB: Turn "should only be true in unit tests" comments into ASSERTs | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joshua Bell <jsbell> | ||||||
| Component: | New Bugs | Assignee: | Joshua Bell <jsbell> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, alecflett, dgrogan, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Joshua Bell
2013-03-29 12:13:56 PDT
Created attachment 195778 [details]
Patch
alecflett@, dgrogan@ - worth it or overkill? Comment on attachment 195778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195778&action=review Definitely worth it. > Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1359 > + ASSERT(m_factory || WebKit::Platform::current()->unitTestSupport()); Does it make sense to put #else ASSERT(m_factory) Do the other ports have unit tests? Comment on attachment 195778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195778&action=review >> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1359 >> + ASSERT(m_factory || WebKit::Platform::current()->unitTestSupport()); > > Does it make sense to put > #else > ASSERT(m_factory) > > Do the other ports have unit tests? Not at this level of intrusion. Waffling on the #else - it's valid for now so probably worth adding. Created attachment 196014 [details]
Patch
abarth@ - could you take a look at this? Comment on attachment 196014 [details] Patch Clearing flags on attachment: 196014 Committed r147381: <http://trac.webkit.org/changeset/147381> All reviewed patches have been landed. Closing bug. |