Bug 113597 – [Chromium] IndexedDB: Turn "should only be true in unit tests" comments into ASSERTs

• Component: New Bugs
• Status: RESOLVED FIXED

[Joshua Bell]

[Chromium] IndexedDB: Turn "should only be true in unit tests" comments into ASSERTs

[Joshua Bell]

Created attachment 195778 [details]
Patch

[Joshua Bell]

alecflett@, dgrogan@ - worth it or overkill?

[David Grogan]

Comment on attachment 195778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195778&action=review

Definitely worth it.

> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1359
> +        ASSERT(m_factory || WebKit::Platform::current()->unitTestSupport());

Does it make sense to put
#else
 ASSERT(m_factory)

Do the other ports have unit tests?

[Joshua Bell]

Comment on attachment 195778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195778&action=review

>> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1359
>> +        ASSERT(m_factory || WebKit::Platform::current()->unitTestSupport());
> 
> Does it make sense to put
> #else
>  ASSERT(m_factory)
> 
> Do the other ports have unit tests?

Not at this level of intrusion. Waffling on the #else - it's valid for now so probably worth adding.

[Joshua Bell]

Created attachment 196014 [details]
Patch

[Joshua Bell]

abarth@ - could you take a look at this?

[WebKit Review Bot]

Comment on attachment 196014 [details]
Patch

Clearing flags on attachment: 196014

Committed r147381: <http://trac.webkit.org/changeset/147381>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.