Bug 113592 – Web Inspector: Crash if script preprocessor returns anything that writes to console

• Component: Web Inspector (Deprecated)
• Status: RESOLVED INVALID

[johnjbarton]

I have a patch that uses Bug 113331 to fix this bug and Bug 113090.

I'll upload a LayoutTest that crashes like this:


crash log for DumpRenderTree (pid 14586):
STDOUT: <empty>
STDERR: Received signal 11 SEGV_MAPERR 000000000000
STDERR:  [0x0000019b31ee] base::debug::StackTrace::StackTrace()
STDERR:  [0x0000019b36e8] base::debug::(anonymous namespace)::StackDumpSignalHandler()
STDERR:  [0x7f3e03abbcb0] <unknown>
STDERR:  [0x0000012a25ff] v8::Function::Call()
STDERR:  [0x000000988e9e] WebCore::InjectedScriptManager::createInjectedScript()
STDERR:  [0x00000093b83b] WebCore::InjectedScriptManager::injectedScriptFor()
STDERR:  [0x0000009e53d2] WebCore::ConsoleMessage::addToFrontend()
STDERR:  [0x00000094fa54] WebCore::InspectorConsoleAgent::addConsoleMessage()
STDERR:  [0x000000950896] WebCore::InspectorConsoleAgent::addMessageToConsole()
STDERR:  [0x0000006a3188] WebCore::InspectorInstrumentation::addMessageToConsoleImpl()
STDERR:  [0x00000097253a] _ZN7WebCoreL18internalAddMessageEPNS_4PageENS_11MessageTypeENS_12MessageLevelEPNS_11ScriptStateEN3WTF10PassRefPtrINS_15ScriptArgumentsEEEbb.constprop.105
STDERR:  [0x000000972ae1] WebCore::Console::log()
STDERR:  [0x000000df13cf] WebCore::ConsoleV8Internal::logMethodCallback()
STDERR:  [0x0000012bc466] v8::internal::Builtin_HandleApiCall()
STDERR:  [0x36933e7062ee] <unknown>
STDERR:   r8: 00007f3dff3f9f98  r9: 00000000000038fa r10: 00007f3dff3fcdf8 r11: 00007f3e02c474d0
STDERR:  r12: 00007fff6af751e0 r13: 000015f774e34d20 r14: 0000000000000000 r15: 000015f773f5e590
STDERR:   di: 0000000000000000  si: 000015f774e34d20  bp: 0000000000000000  bx: fffffffffffffff0
STDERR:   dx: 0000000000000003  ax: 000015f774e34d60  cx: 00007fff6af750f0  sp: 00007fff6af75020
STDERR:   ip: 00000000012a25ff efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000004
STDERR:  trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000000

[johnjbarton]

Created attachment 195768 [details]
Patch

[WebKit Review Bot]

Comment on attachment 195768 [details]
Patch

Attachment 195768 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17253710

New failing tests:
inspector/debugger/debugger-script-preprocessor.html

[WebKit Review Bot]

Created attachment 195779 [details]
Archive of layout-test-results from gce-cr-linux-07 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Build Bot]

Comment on attachment 195768 [details]
Patch

Attachment 195768 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17323479

New failing tests:
inspector/debugger/debugger-script-preprocessor.html

[Build Bot]

Created attachment 195808 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2