Bug 113587
| Summary: | [EFL] build fails because of libsoup deprecated declarations | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ed Bartosh <bartosh> |
| Component: | WebKit EFL | Assignee: | Ed Bartosh <bartosh> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | danw, kalyan.kondapally, lucas.de.marchi, ryuan.choi |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ed Bartosh
Here is the build failure:
/home/ed/git/wk/WebKit/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp: In function `void WebCore::ensureSessionIsInitialized(SoupSession*)':
/home/ed/git/wk/WebKit/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:292:44: error: `GType soup_requester_get_type()' is deprecated (declared at /usr/local/include/libsoup-2.4/libsoup/soup-requester.h:52) [-Werror=deprecated-declarations]
/home/ed/git/wk/WebKit/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:292:44: error: `GType soup_requester_get_type()' is deprecated (declared at /usr/local/include/libsoup-2.4/libsoup/soup-requester.h:52) [-Werror=deprecated-declarations]
/home/ed/git/wk/WebKit/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:293:36: error: `SoupRequester* soup_requester_new()' is deprecated (declared at /usr/local/include/libsoup-2.4/libsoup/soup-requester.h:56) [-Werror=deprecated-declarations]
/home/ed/git/wk/WebKit/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:293:55: error: `SoupRequester* soup_requester_new()' is deprecated (declared at /usr/local/include/libsoup-2.4/libsoup/soup-requester.h:56) [-Werror=deprecated-declarations]
/home/ed/git/wk/WebKit/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp: In function `bool WebCore::createSoupRequestAndMessageForHandle(WebCore::ResourceHandle*, const WebCore::ResourceRequest&, bool)':
/home/ed/git/wk/WebKit/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:989:32: error: `GType soup_requester_get_type()' is deprecated (declared at /usr/local/include/libsoup-2.4/libsoup/soup-requester.h:52) [-Werror=deprecated-declarations]
/home/ed/git/wk/WebKit/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:989:32: error: `GType soup_requester_get_type()' is deprecated (declared at /usr/local/include/libsoup-2.4/libsoup/soup-requester.h:52) [-Werror=deprecated-declarations]
/home/ed/git/wk/WebKit/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:989:32: error: `GType soup_requester_get_type()' is deprecated (declared at /usr/local/include/libsoup-2.4/libsoup/soup-requester.h:52) [-Werror=deprecated-declarations]
/home/ed/git/wk/WebKit/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:989:32: error: `GType soup_requester_get_type()' is deprecated (declared at /usr/local/include/libsoup-2.4/libsoup/soup-requester.h:52) [-Werror=deprecated-declarations]
/home/ed/git/wk/WebKit/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:997:34: error: `SoupRequest* soup_requester_request_uri(SoupRequester*, SoupURI*, GError**)' is deprecated (declared at /usr/local/include/libsoup-2.4/libsoup/soup-requester.h:66): Use 'soup_session_request_uri' instead [-Werror=deprecated-declarations]
/home/ed/git/wk/WebKit/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:997:102: error: `SoupRequest* soup_requester_request_uri(SoupRequester*, SoupURI*, GError**)' is deprecated (declared at /usr/local/include/libsoup-2.4/libsoup/soup-requester.h:66): Use 'soup_session_request_uri' instead [-Werror=deprecated-declarations]
cc1plus: all warnings being treated as errors
make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/platform/network/soup/ResourceHandleSoup.cpp.o] Error 1
make[1]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/all] Error 2
make: *** [all] Error 2
I'll try to fix it as it stops my current work.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ed Bartosh
It turned out that I used libsoup from master. It will hit us in future, but not now. Resolved/invalid.
Dan Winship
(In reply to comment #1)
> It will hit us in future, but not now. Resolved/invalid.
This can be fixed now to make it compile happily with both old and new libsoups though; just add an appropriate SOUP_VERSION_MIN_REQUIRED to the CPPFLAGS to tell it what the oldest version of libsoup you want to be able to compile against is, and that will tweak things so that only functions that were deprecated as of that release get the __deprecated__ attribute.
Eg, if you currently depend on libsoup >= 2.38, you'd add
-DSOUP_VERSION_MIN_REQUIRED=SOUP_VERSION_2_38
Ryuan Choi
I didn't realize this, but it was fixed at Bug 145154
*** This bug has been marked as a duplicate of bug 145154 ***