| Summary: | Implement DOMFutures | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED WONTFIX | ||||||||||
| Severity: | Normal | CC: | abarth, annevk, buildbot, dglazkov, domenic, ericbidelman, esprehn+autocc, gyuyoung.kim, kenneth, laszlo.gombos, mounir, ojan.autocc, peter, peter+ews, pivisko, rakuco, rego+ews, rniwa, syoichi, webkit.bugzilla, webkit-ews, webkit.review.bot, xan.lopez | ||||||||
| Priority: | P2 | Keywords: | WebExposed | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| URL: | http://dom.spec.whatwg.org/#futures | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Chris Dumez
2013-03-29 05:41:18 PDT
Created attachment 195814 [details]
WIP Patch
Comment on attachment 195814 [details] WIP Patch Attachment 195814 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/17255654 Comment on attachment 195814 [details] WIP Patch Attachment 195814 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17311746 Comment on attachment 195814 [details] WIP Patch Attachment 195814 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17257696 Comment on attachment 195814 [details] WIP Patch Attachment 195814 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17327415 Comment on attachment 195814 [details] WIP Patch Attachment 195814 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17356136 Comment on attachment 195814 [details] WIP Patch Attachment 195814 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17327421 Comment on attachment 195814 [details] WIP Patch Attachment 195814 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17330451 Comment on attachment 195814 [details] WIP Patch Attachment 195814 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17332298 Created attachment 195860 [details]
WIP Patch
I would like to review this patch before it lands. (In reply to comment #11) > I would like to review this patch before it lands. Sure. Is it better to send an email to webkit-dev as well to announce that I'm working on this? > Sure. Is it better to send an email to webkit-dev as well to announce that I'm working on this?
That might be worthwhile. I'm more interested in the technical aspects of the patch (e.g., the usage of ScriptValue). It looks like your work is still in progress, so it didn't seem appropriate to review the current patch.
(In reply to comment #13) > > Sure. Is it better to send an email to webkit-dev as well to announce that I'm working on this? > > That might be worthwhile. I'm more interested in the technical aspects of the patch (e.g., the usage of ScriptValue). It looks like your work is still in progress, so it didn't seem appropriate to review the current patch. This is useful feedback, thanks. Could you please explain the issue with using ScriptValue? Is there a better way to represent the WebIDL "any" type? I see that it is used quite a lot in the IndexedDB code, which I used as reference. I tried compiling the patch for Chromium to see if I was missing something related to V8 but the generic code seems to compile fine as ScriptValue also exists for V8 (although with a different API but it does not matter much for my use). You almost certainly should not be using ScriptValue. Essentially any time we use ScriptValue, it's a memory leak. I'd have to study this feature in more detail to figure out the best way of implementing it. Created attachment 195972 [details]
WIP Patch
Promises should now be implemented, not futures. |