Bug 113569

Summary: Newly added test fast/events/event-attribute.html fails after r147205
Product: WebKit Reporter: Zoltan Arvai <zarvai>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: keishi, ossy, rniwa, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 86363, 87008    

Zoltan Arvai
Reported 2013-03-29 05:15:51 PDT
Test fails on GTK and QT WK1 (but passes os Qt WK2) --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/events/event-attribute-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/events/event-attribute-actual.txt @@ -41,8 +41,8 @@ PASS /*img*/ typeof (element["ontouchmove"]) is "function" PASS /*img*/ typeof (element["ontouchend"]) is "function" PASS /*img*/ typeof (element["ontouchcancel"]) is "function" -PASS /*img*/ typeof (element["onwebkitfullscreenchange"]) is "function" -PASS /*img*/ typeof (element["onwebkitfullscreenerror"]) is "function" +FAIL /*img*/ typeof (element["onwebkitfullscreenchange"]) should be function. Was undefined. +FAIL /*img*/ typeof (element["onwebkitfullscreenerror"]) should be function. Was undefined. PASS /*img*/ typeof (element["onabort"]) is "function" PASS /*img*/ typeof (element["onchange"]) is "function" PASS /*img*/ typeof (element["onreset"]) is "function" @@ -85,8 +85,8 @@ PASS /*script*/ typeof (element["ontouchmove"]) is "function" PASS /*script*/ typeof (element["ontouchend"]) is "function" PASS /*script*/ typeof (element["ontouchcancel"]) is "function" -PASS /*script*/ typeof (element["onwebkitfullscreenchange"]) is "function" -PASS /*script*/ typeof (element["onwebkitfullscreenerror"]) is "function" +FAIL /*script*/ typeof (element["onwebkitfullscreenchange"]) should be function. Was undefined. +FAIL /*script*/ typeof (element["onwebkitfullscreenerror"]) should be function. Was undefined. PASS /*script*/ typeof (element["onabort"]) is "function" PASS /*script*/ typeof (element["onchange"]) is "function" PASS /*script*/ typeof (element["onreset"]) is "function" @@ -129,8 +129,8 @@ PASS /*video*/ typeof (element["ontouchmove"]) is "function" PASS /*video*/ typeof (element["ontouchend"]) is "function" PASS /*video*/ typeof (element["ontouchcancel"]) is "function" -PASS /*video*/ typeof (element["onwebkitfullscreenchange"]) is "function" -PASS /*video*/ typeof (element["onwebkitfullscreenerror"]) is "function" +FAIL /*video*/ typeof (element["onwebkitfullscreenchange"]) should be function. Was undefined. +FAIL /*video*/ typeof (element["onwebkitfullscreenerror"]) should be function. Was undefined. PASS /*video*/ typeof (element["onabort"]) is "function" PASS /*video*/ typeof (element["onchange"]) is "function" PASS /*video*/ typeof (element["onreset"]) is "function" @@ -173,8 +173,8 @@ PASS /*div*/ typeof (element["ontouchmove"]) is "function" PASS /*div*/ typeof (element["ontouchend"]) is "function" PASS /*div*/ typeof (element["ontouchcancel"]) is "function" -PASS /*div*/ typeof (element["onwebkitfullscreenchange"]) is "function" -PASS /*div*/ typeof (element["onwebkitfullscreenerror"]) is "function" +FAIL /*div*/ typeof (element["onwebkitfullscreenchange"]) should be function. Was undefined. +FAIL /*div*/ typeof (element["onwebkitfullscreenerror"]) should be function. Was undefined. PASS /*div*/ typeof (element["onabort"]) is "function" PASS /*div*/ typeof (element["onchange"]) is "function" PASS /*div*/ typeof (element["onreset"]) is "function" @@ -217,8 +217,8 @@ PASS /*form*/ typeof (element["ontouchmove"]) is "function" PASS /*form*/ typeof (element["ontouchend"]) is "function" PASS /*form*/ typeof (element["ontouchcancel"]) is "function" -PASS /*form*/ typeof (element["onwebkitfullscreenchange"]) is "function" -PASS /*form*/ typeof (element["onwebkitfullscreenerror"]) is "function" +FAIL /*form*/ typeof (element["onwebkitfullscreenchange"]) should be function. Was undefined. +FAIL /*form*/ typeof (element["onwebkitfullscreenerror"]) should be function. Was undefined. PASS /*form*/ typeof (element["onabort"]) is "function" PASS /*form*/ typeof (element["onchange"]) is "function" PASS /*form*/ typeof (element["onreset"]) is "function" @@ -261,8 +261,8 @@ PASS /*input*/ typeof (element["ontouchmove"]) is "function" PASS /*input*/ typeof (element["ontouchend"]) is "function" PASS /*input*/ typeof (element["ontouchcancel"]) is "function" -PASS /*input*/ typeof (element["onwebkitfullscreenchange"]) is "function" -PASS /*input*/ typeof (element["onwebkitfullscreenerror"]) is "function" +FAIL /*input*/ typeof (element["onwebkitfullscreenchange"]) should be function. Was undefined. +FAIL /*input*/ typeof (element["onwebkitfullscreenerror"]) should be function. Was undefined. PASS /*input*/ typeof (element["onabort"]) is "function" PASS /*input*/ typeof (element["onchange"]) is "function" PASS /*input*/ typeof (element["onreset"]) is "function"
Attachments
Add attachment proposed patch, testcase, etc.
Zoltan Arvai
Comment 1 2013-03-29 05:26:38 PDT
Skipped on Qt in http://trac.webkit.org/changeset/147207. Please unskip it with proper fix.
Ryosuke Niwa
Comment 2 2013-03-29 10:08:01 PDT
My guess is that Qt doesn't enable fullscreen API, in which case this is the expected result.
Ryosuke Niwa
Comment 3 2013-03-29 10:09:32 PDT
The right thing to do here is to check in the expected result with FAIL rather than skipping it.
Csaba Osztrogonác
Comment 4 2013-04-08 04:05:38 PDT
(In reply to comment #2) > My guess is that Qt doesn't enable fullscreen API, in which case this is the expected result. (In reply to comment #3) > The right thing to do here is to check in the expected result with FAIL rather than skipping it. Thanks for checking it. Fullscreen API is really disabled on Qt-WK1. I agree, in this case checking these FAILs are reasonable.
Note You need to log in before you can comment on or make changes to this bug.