Bug 113554

Summary: Simplified bytecode generation by unforking "condition context" codegen
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Geoffrey Garen
Reported 2013-03-28 20:02:03 PDT
Simplified bytecode generation by unforking "condition context" codegen
Attachments
Patch (12.92 KB, patch)
2013-03-28 20:11 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (15.31 KB, patch)
2013-03-28 21:05 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2013-03-28 20:11:23 PDT
Created attachment 195691 [details] Patch
Oliver Hunt
Comment 2 2013-03-28 20:22:36 PDT
Comment on attachment 195691 [details] Patch Given you're doing this work in a bunch of place anyway, can we change from a bool to an enum for the fallsthrough parameter?
Geoffrey Garen
Comment 3 2013-03-28 21:03:31 PDT
(In reply to comment #2) > (From update of attachment 195691 [details]) > Given you're doing this work in a bunch of place anyway, can we change from a bool to an enum for the fallsthrough parameter? Seems a bit far afield, but OK.
Geoffrey Garen
Comment 4 2013-03-28 21:05:14 PDT
Created attachment 195694 [details] Patch
Mark Hahnenberg
Comment 5 2013-03-29 11:40:52 PDT
Comment on attachment 195694 [details] Patch r=me
Geoffrey Garen
Comment 6 2013-03-29 12:10:26 PDT
Comment on attachment 195694 [details] Patch Clearing flags on attachment: 195694 Committed r147234: <http://trac.webkit.org/changeset/147234>
Geoffrey Garen
Comment 7 2013-03-29 12:10:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.