Bug 113552

Summary:

[EFL] Add a decoration image to search input field

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

WebKit EFL

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kenneth, laszlo.gombos, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Gyuyoung Kim

Reported 2013-03-28 18:37:46 PDT

Though EFL port has a decoration image for input search field, we don't use it. This patch is to use it in input search field.

Attachments
Patch (323.98 KB, patch) 2013-03-28 18:41 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (323.98 KB, patch) 2013-03-28 18:51 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (604.91 KB, patch) 2013-04-03 04:23 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2013-03-28 18:41:51 PDT

Created attachment 195687 [details] Patch

WebKit Review Bot

Comment 2 2013-03-28 18:44:46 PDT

Attachment 195687 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/efl/fast/css/input-search-padding-expected.png', u'LayoutTests/platform/efl/fast/css/input-search-padding-expected.txt', u'LayoutTests/platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt', u'LayoutTests/platform/efl/fast/css/text-overflow-input-expected.png', u'LayoutTests/platform/efl/fast/css/text-overflow-input-expected.txt', u'LayoutTests/platform/efl/fast/forms/box-shadow-override-expected.txt', u'LayoutTests/platform/efl/fast/forms/control-restrict-line-height-expected.png', u'LayoutTests/platform/efl/fast/forms/control-restrict-line-height-expected.txt', u'LayoutTests/platform/efl/fast/forms/input-appearance-height-expected.txt', u'LayoutTests/platform/efl/fast/forms/placeholder-position-expected.txt', u'LayoutTests/platform/efl/fast/forms/placeholder-pseudo-style-expected.txt', u'LayoutTests/platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt', u'LayoutTests/platform/efl/fast/forms/searchfield-heights-expected.png', u'LayoutTests/platform/efl/fast/forms/searchfield-heights-expected.txt', u'LayoutTests/platform/efl/fast/repaint/search-field-cancel-expected.txt', u'LayoutTests/platform/efl/fast/replaced/width100percent-searchfield-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp']" exit_code: 1 Source/WebCore/platform/efl/RenderThemeEfl.cpp:77: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gyuyoung Kim

Comment 3 2013-03-28 18:51:44 PDT

Created attachment 195688 [details] Patch

Chris Dumez

Comment 4 2013-03-29 00:21:44 PDT

Comment on attachment 195688 [details] Patch LGTM.

Build Bot

Comment 5 2013-03-29 14:09:46 PDT

Comment on attachment 195688 [details] Patch Attachment 195688 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17323452

Gyuyoung Kim

Comment 6 2013-03-31 18:41:21 PDT

(In reply to comment #5) > (From update of attachment 195688 [details]) > Attachment 195688 [details] did not pass win-ews (win): > Output: http://webkit-commit-queue.appspot.com/results/17323452 Unrelated.