Summary: | [EFL] Add a decoration image to search input field | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | kenneth, laszlo.gombos, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Gyuyoung Kim
2013-03-28 18:37:46 PDT
Created attachment 195687 [details]
Patch
Attachment 195687 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/efl/fast/css/input-search-padding-expected.png', u'LayoutTests/platform/efl/fast/css/input-search-padding-expected.txt', u'LayoutTests/platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt', u'LayoutTests/platform/efl/fast/css/text-overflow-input-expected.png', u'LayoutTests/platform/efl/fast/css/text-overflow-input-expected.txt', u'LayoutTests/platform/efl/fast/forms/box-shadow-override-expected.txt', u'LayoutTests/platform/efl/fast/forms/control-restrict-line-height-expected.png', u'LayoutTests/platform/efl/fast/forms/control-restrict-line-height-expected.txt', u'LayoutTests/platform/efl/fast/forms/input-appearance-height-expected.txt', u'LayoutTests/platform/efl/fast/forms/placeholder-position-expected.txt', u'LayoutTests/platform/efl/fast/forms/placeholder-pseudo-style-expected.txt', u'LayoutTests/platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt', u'LayoutTests/platform/efl/fast/forms/searchfield-heights-expected.png', u'LayoutTests/platform/efl/fast/forms/searchfield-heights-expected.txt', u'LayoutTests/platform/efl/fast/repaint/search-field-cancel-expected.txt', u'LayoutTests/platform/efl/fast/replaced/width100percent-searchfield-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp']" exit_code: 1
Source/WebCore/platform/efl/RenderThemeEfl.cpp:77: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 195688 [details]
Patch
Comment on attachment 195688 [details]
Patch
LGTM.
Comment on attachment 195688 [details] Patch Attachment 195688 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17323452 (In reply to comment #5) > (From update of attachment 195688 [details]) > Attachment 195688 [details] did not pass win-ews (win): > Output: http://webkit-commit-queue.appspot.com/results/17323452 Unrelated. CC'ing Kenneth and Laszlo. Created attachment 196326 [details]
Patch
Comment on attachment 196326 [details]
Patch
LGTM.
Comment on attachment 196326 [details] Patch Clearing flags on attachment: 196326 Committed r147607: <http://trac.webkit.org/changeset/147607> All reviewed patches have been landed. Closing bug. |