Bug 113544

Summary: GraphicsLayerCA::recomputeVisibleRects() shouldn't actually set the visible rect
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, esprehn+autocc, ojan.autocc, simon.fraser, thorton, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Simon Fraser (smfr) 2013-03-28 16:26:00 PDT
GraphicsLayerCA::recomputeVisibleRects() shouldn't actually set the visible rect
Comment 1 Simon Fraser (smfr) 2013-03-28 16:31:33 PDT
Created attachment 195675 [details]
Patch
Comment 2 Tim Horton 2013-03-28 16:39:08 PDT
Comment on attachment 195675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195675&action=review

> Source/WebCore/ChangeLog:14
> +        rect, it would need to make new tiles (which happens layer during a flush).

Layers on the brain?

> Source/WebCore/rendering/RenderLayerCompositor.h:140
> +    void noteVisibleRectChanged();

Is "note" usually used for things that actually affect behavior? (I have no idea).

didChangeVisibleRect?
Comment 3 Simon Fraser (smfr) 2013-04-09 14:41:11 PDT
http://trac.webkit.org/changeset/147186