Bug 113534

Summary: Convert some flexbox layout tests to using flexbox.css
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: cbiesinger, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tony Chang
Reported 2013-03-28 13:19:51 PDT
Convert some flexbox layout tests to using flexbox.css
Attachments
Patch (30.77 KB, patch)
2013-03-28 13:20 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (31.51 KB, patch)
2013-03-28 16:23 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2013-03-28 13:20:53 PDT
Created attachment 195631 [details] Patch
Christian Biesinger
Comment 2 2013-03-28 16:16:30 PDT
Comment on attachment 195631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195631&action=review > LayoutTests/css3/flexbox/flex-align-end.html:20 > + flex: none; Can't you use .flex-none from flexbox.css?
Tony Chang
Comment 3 2013-03-28 16:23:22 PDT
Created attachment 195672 [details] Patch
Tony Chang
Comment 4 2013-03-28 16:23:43 PDT
(In reply to comment #2) > (From update of attachment 195631 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195631&action=review > > > LayoutTests/css3/flexbox/flex-align-end.html:20 > > + flex: none; > > Can't you use .flex-none from flexbox.css? Sure, done.
WebKit Review Bot
Comment 5 2013-03-28 16:44:28 PDT
Comment on attachment 195672 [details] Patch Clearing flags on attachment: 195672 Committed r147183: <http://trac.webkit.org/changeset/147183>
WebKit Review Bot
Comment 6 2013-03-28 16:44:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.