Bug 113519
| Summary: | for flex items, percent margins and paddings should resolve against their respective dimension | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | cbiesinger, claude.pache, dholbert, m.goleb+bugzilla, webkit |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tony Chang
Normally, margin top and margin bottom resolve against the width of the containing block, but the working group decided that for flex items, we should resolve against the height of the containing block.
http://lists.w3.org/Archives/Public/www-style/2013Mar/0688.html
This should be an easy change to make. See RenderFlexibleBox::computeChildMarginValue.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Christian Biesinger
*** Bug 120003 has been marked as a duplicate of this bug. ***
Daniel Holbert
*** Bug 126809 has been marked as a duplicate of this bug. ***
Michał Gołębiowski-Owczarek
Both Edge & Firefox teams have committed to change to align with the Chrome/Safari behavior. The spec also got an update to mandate this behavior: https://drafts.csswg.org/css-grid-1/#item-margins
It sounds that this issue should be closed as "Won't Fix".
Daniel Holbert
Right -- and the spec changed, too, such that WebKit is now correct according to the spec.
So really this could now be "Resolved|Invalid", in the sense that WebKit is matching what the spec requires, i.e. the reported behavior is actually correct/intentional & not a bug.
(At least, that'd be the correct resolution if this were in the Mozilla/Firefox bug tracker -- I'm not sure if the bug-resolution semantics are the same in WebKit's bug tracker.)