| Summary: | use XMLHttpRequestResponseType enumeration in XMLHttpRequest.idl | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | arno. <a.renevier> |
| Component: | WebKit Misc. | Assignee: | arno. <a.renevier> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abarth, ap, crogers, esprehn+autocc, haraken, nbarth, ojan.autocc, webkit.review.bot |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Attachments: | |||
|
Description
arno.
2013-03-28 10:45:13 PDT
Created attachment 195600 [details]
patch proposal
Comment on attachment 195600 [details] patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=195600&action=review > Source/WebCore/ChangeLog:16 > + Already covered by > + xmlhttprequest-responsetype-set-invalidtype-expected.txt Is there any test for valid types? > Source/WebCore/xml/XMLHttpRequest.idl:34 > + "json", I thought "json" is not supported: https://bugs.webkit.org/show_bug.cgi?id=73648 Maybe it would be better to comment out "json" with a FIXME. Created attachment 195641 [details]
updated patch: comment json in idl + tests all valid types in xmlhttprequest-responsetype-set-invalidtype
Comment on attachment 195641 [details] updated patch: comment json in idl + tests all valid types in xmlhttprequest-responsetype-set-invalidtype View in context: https://bugs.webkit.org/attachment.cgi?id=195641&action=review Looks OK with nits. > LayoutTests/ChangeLog:12 > + * fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt: Let's rename the test to xmlhttprequest-set-responsetype.html, as we're now testing valid types as well. Created attachment 195645 [details]
updated patch: rename xmlhttprequest-responsetype-set-invalidtype to xmlhttprequest-set-responsetype
Comment on attachment 195645 [details]
updated patch: rename xmlhttprequest-responsetype-set-invalidtype to xmlhttprequest-set-responsetype
LGTM
Comment on attachment 195645 [details]
updated patch: rename xmlhttprequest-responsetype-set-invalidtype to xmlhttprequest-set-responsetype
Oops, it looks like you forgot to update xmlhttprequest-set-responsetype-expected.txt.
Created attachment 195648 [details]
updated patch: udpate xmlhttprequest-set-responsetype-expected; hopefully this one is good
Comment on attachment 195648 [details]
updated patch: udpate xmlhttprequest-set-responsetype-expected; hopefully this one is good
Looks good.
Comment on attachment 195648 [details] updated patch: udpate xmlhttprequest-set-responsetype-expected; hopefully this one is good Clearing flags on attachment: 195648 Committed r147172: <http://trac.webkit.org/changeset/147172> All reviewed patches have been landed. Closing bug. |