Bug 113507

Summary: Web Inspector: add memory instrumentation for StringBuffer
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, benjamin, buildbot, cc-bugs, cmarcelo, jamesr, keishi, loislo, ojan.autocc, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Yury Semikhatsky
Reported 2013-03-28 08:25:07 PDT
We see quite big blocks allocated by StringBuffer, they should be instrumented.
Attachments
Patch (4.77 KB, patch)
2013-03-28 08:27 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (7.23 KB, patch)
2013-03-29 05:47 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (1.73 KB, patch)
2013-03-29 06:52 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2013-03-28 08:27:10 PDT
Created attachment 195572 [details] Patch
Ilya Tikhonovsky
Comment 2 2013-03-28 08:55:39 PDT
Comment on attachment 195572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195572&action=review > Source/WTF/wtf/MemoryInstrumentationString.h:77 > + MemoryClassInfo info(memoryObjectInfo, stringBuffer->characters(), 0, sizeof(CharType) * stringBuffer->length()); You have to report the address of stringBuffer and report characters() as the member. if it is a part of memory chunk of stringBuilder then you need to calculate the size for stringBuilder explicitly. See the instrumentation for String.
Build Bot
Comment 3 2013-03-28 09:02:39 PDT
Comment on attachment 195572 [details] Patch Attachment 195572 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17358068
Yury Semikhatsky
Comment 4 2013-03-29 05:47:06 PDT
Created attachment 195730 [details] Patch
Yury Semikhatsky
Comment 5 2013-03-29 05:47:42 PDT
(In reply to comment #2) > (From update of attachment 195572 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195572&action=review > > > Source/WTF/wtf/MemoryInstrumentationString.h:77 > > + MemoryClassInfo info(memoryObjectInfo, stringBuffer->characters(), 0, sizeof(CharType) * stringBuffer->length()); > > You have to report the address of stringBuffer and report characters() as the member. > if it is a part of memory chunk of stringBuilder then you need to calculate the size for stringBuilder explicitly. > See the instrumentation for String. You're right. Fixed.
Ilya Tikhonovsky
Comment 6 2013-03-29 06:26:48 PDT
Comment on attachment 195730 [details] Patch please extract libjpeg change into a separate patch
Yury Semikhatsky
Comment 7 2013-03-29 06:52:43 PDT
Created attachment 195738 [details] Patch
Ilya Tikhonovsky
Comment 8 2013-03-29 06:54:04 PDT
Comment on attachment 195738 [details] Patch LGTM
WebKit Review Bot
Comment 9 2013-04-01 02:39:49 PDT
Comment on attachment 195738 [details] Patch Clearing flags on attachment: 195738 Committed r147313: <http://trac.webkit.org/changeset/147313>
WebKit Review Bot
Comment 10 2013-04-01 02:39:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.