Bug 113502

Summary: CSP 1.1: Remove 'type' parameter from CSPDirectiveList::checkSourceAndReportViolation.
Product: WebKit Reporter: Mike West <mkwst>
Component: New BugsAssignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, jer.noble, mkwst+watchlist, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64
none
Patch
none
Patch for landing none

Mike West
Reported 2013-03-28 05:39:48 PDT
CSP 1.1: Remove 'type' parameter from CSPDirectiveList::checkSourceAndReportViolation.
Attachments
Patch (19.96 KB, patch)
2013-03-28 05:43 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64 (1.30 MB, application/zip)
2013-03-28 06:32 PDT, WebKit Review Bot 		no flags
Details
Patch (21.47 KB, patch)
2013-03-28 06:39 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
Patch for landing (21.44 KB, patch)
2013-04-01 10:55 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2013-03-28 05:43:10 PDT
Created attachment 195539 [details] Patch
WebKit Review Bot
Comment 2 2013-03-28 06:32:25 PDT
Comment on attachment 195539 [details] Patch Attachment 195539 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17353093 New failing tests: media/csp-blocks-video.html
WebKit Review Bot
Comment 3 2013-03-28 06:32:28 PDT
Created attachment 195554 [details] Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-02 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Mike West
Comment 4 2013-03-28 06:39:50 PDT
Created attachment 195557 [details] Patch
Mike West
Comment 5 2013-03-29 13:04:21 PDT
Would you mind taking a look at this quick refactoring, Adam?
Adam Barth
Comment 6 2013-03-30 10:53:21 PDT
Comment on attachment 195557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195557&action=review > Source/WebCore/page/ContentSecurityPolicy.cpp:1053 > + String prefix = String(); There's no need for the "= String()" here. The compiler automatically calls the default constructor.
Mike West
Comment 7 2013-04-01 10:55:58 PDT
Created attachment 195994 [details] Patch for landing
WebKit Review Bot
Comment 8 2013-04-01 11:23:06 PDT
Comment on attachment 195994 [details] Patch for landing Clearing flags on attachment: 195994 Committed r147346: <http://trac.webkit.org/changeset/147346>
WebKit Review Bot
Comment 9 2013-04-01 11:23:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.