| Summary: | CSP 1.1: Remove 'type' parameter from CSPDirectiveList::checkSourceAndReportViolation. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mike West <mkwst> | ||||||||||
| Component: | New Bugs | Assignee: | Mike West <mkwst> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | abarth, dglazkov, eric.carlson, feature-media-reviews, jer.noble, mkwst+watchlist, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Mike West
2013-03-28 05:39:48 PDT
Created attachment 195539 [details]
Patch
Comment on attachment 195539 [details] Patch Attachment 195539 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17353093 New failing tests: media/csp-blocks-video.html Created attachment 195554 [details]
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Created attachment 195557 [details]
Patch
Would you mind taking a look at this quick refactoring, Adam? Comment on attachment 195557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195557&action=review > Source/WebCore/page/ContentSecurityPolicy.cpp:1053 > + String prefix = String(); There's no need for the "= String()" here. The compiler automatically calls the default constructor. Created attachment 195994 [details]
Patch for landing
Comment on attachment 195994 [details] Patch for landing Clearing flags on attachment: 195994 Committed r147346: <http://trac.webkit.org/changeset/147346> All reviewed patches have been landed. Closing bug. |