Bug 11348

Summary:

[S60] File transaction should handle the case of escaped file schemed url

Product:

WebKit

Reporter:

Wei Liu <wei.liu>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Major

Priority:

Version:

420+

Hardware:

S60 Hardware

OS:

S60 3rd edition

Attachments:

Description	Flags
file transaction fix for escaped file url	Sachin.Padma: review-
Files: BrCtl.cpp, FileTransaction.cpp	Sachin.Padma: review-
Files: BrCtl.cpp, FileTransaction.cpp	joseph.ligman: review-
Files: FileTransaction.cpp	Sachin.Padma: review+

Wei Liu

Reported 2006-10-18 10:37:44 PDT

File transaction should handle the case of escaped file schemed url

Attachments
file transaction fix for escaped file url (8.88 KB, patch) 2006-10-18 10:51 PDT, Wei Liu	Sachin.Padma: review-	Details Formatted Diff Diff
Files: BrCtl.cpp, FileTransaction.cpp (6.33 KB, patch) 2006-10-27 13:29 PDT, Joseph Ligman	Sachin.Padma: review-	Details Formatted Diff Diff
Files: BrCtl.cpp, FileTransaction.cpp (6.34 KB, patch) 2006-10-30 11:32 PST, Joseph Ligman	joseph.ligman: review-	Details Formatted Diff Diff
Files: FileTransaction.cpp (1.69 KB, patch) 2006-11-01 10:53 PST, Joseph Ligman	Sachin.Padma: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Wei Liu

Comment 1 2006-10-18 10:51:08 PDT

Created attachment 11136 [details] file transaction fix for escaped file url

Sachin Padma

Comment 2 2006-10-20 12:50:40 PDT

Comment on attachment 11136 [details] file transaction fix for escaped file url The escaping should be generic.

Joseph Ligman

Comment 3 2006-10-27 13:29:45 PDT

Created attachment 11258 [details] Files: BrCtl.cpp, FileTransaction.cpp This patch uses the TUriParser::GetFileNameL(EUriFileNameFull) to generate the file path.

Joseph Ligman

Comment 4 2006-10-30 11:32:40 PST

Created attachment 11287 [details] Files: BrCtl.cpp, FileTransaction.cpp Added a TRAP_IGNORE around TUriParser::GetFileNameL since invalid paths should return NULL and are not expected to leave.

Joseph Ligman

Comment 5 2006-11-01 10:53:54 PST

Created attachment 11330 [details] Files: FileTransaction.cpp Remove any escaped characters in the file path with EscapeUtils::EscapeDecodeL.

Sachin Padma

Comment 6 2006-11-03 10:19:57 PST

Comment on attachment 11330 [details] Files: FileTransaction.cpp r=me

Sachin Padma

Comment 7 2006-11-03 11:10:11 PST

committed as r17576

Note You need to log in before you can comment on or make changes to this bug.