Summary: | [WebKit2] Need SPI to determine whether a plug-in is blocked | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Sam Weinig
2013-03-27 18:03:22 PDT
Created attachment 195451 [details]
Patch
Attachment 195451 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/C/WKAPICast.h', u'Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.h', u'Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.mm', u'Source/WebKit2/UIProcess/Plugins/PluginInfoStore.cpp', u'Source/WebKit2/UIProcess/Plugins/PluginInfoStore.h', u'Source/WebKit2/UIProcess/Plugins/mac/PluginInfoStoreMac.mm', u'Source/WebKit2/UIProcess/WebLoaderClient.cpp']" exit_code: 1
Source/WebKit2/UIProcess/API/C/WKAPICast.h:409: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
Source/WebKit2/UIProcess/API/C/WKAPICast.h:424: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 195451 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195451&action=review >> Source/WebKit2/UIProcess/API/C/WKAPICast.h:409 >> + case PluginModuleLoadNormally: > > A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Please fix the indentation. >> Source/WebKit2/UIProcess/API/C/WKAPICast.h:424 >> + case kWKPluginLoadPolicyLoadNormally: > > A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Please fix the indentation. > Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.h:56 > +WK_EXPORT WKDictionaryRef WKContextCopyPlugInInfoForBundleIdetifier(WKContextRef context, WKStringRef plugInBundleIdentifier); Idetifier? > Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.mm:89 > +WKDictionaryRef WKContextCopyPlugInInfoForBundleIdetifier(WKContextRef contextRef, WKStringRef plugInBundleIdentifierRef) Idetifier?? > Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.mm:103 > + RefPtr<ImmutableDictionary> dictionary = ImmutableDictionary::adopt(map); > + > + return toAPI(dictionary.release().leakRef()); I don't think you need to the local variable here. > Source/WebKit2/UIProcess/Plugins/mac/PluginInfoStoreMac.mm:174 > +PluginModuleInfo PluginInfoStore::findPluginWithBundleIdentifer(const String& bundleIdentifer) Identifer? How many ways are there to misspell identifier? Created attachment 195470 [details]
Patch
Comment on attachment 195470 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195470&action=review > Tools/ChangeLog:18 > +2013-03-27 Gustavo Noronha Silva <gns@gnome.org> > + > + [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup > + https://bugs.webkit.org/show_bug.cgi?id=113203 > + > + Reviewed by Philippe Normand. > + > + We build our libsoup without GNOME support. gst-plugins-good does separate > + pkg-config checks for libsoup-gnome and libsoup, causing the build to use > + libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to > + build failures as the headers of those diverge. We do not use souphttpsrc, so > + disable it when building gst-plugins-good. > + > + * gtk/jhbuild.modules: disable soup support in gst-plugins-good. > + > 2013-03-27 Ryosuke Niwa <rniwa@webkit.org> > > Build fix after r146852. Please another reference to the Lion leaks builder. Wat > Tools/gtk/jhbuild.modules:266 > <branch repo="gstreamer" module="gst-plugins-base" checkoutdir="gst-plugins-base" tag="1.0.4"/> > </autotools> > > - <autotools id="gst-plugins-good" autogenargs="--disable-examples"> > + <autotools id="gst-plugins-good" autogenargs="--disable-examples --disable-soup"> > <dependencies> > <dep package="gst-plugins-base"/> > </dependencies> I don't think you meant to include this. Committed r147052: <http://trac.webkit.org/changeset/147052> |