Bug 113456

Summary:

use CanvasWindingRule enumeration in CanvasRenderingContext2D.idl

Product:

WebKit

Reporter:

arno. <a.renevier>

Component:

Canvas

Assignee:

arno. <a.renevier>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cabanier, esprehn+autocc, haraken, krit, nbarth, ojan.autocc, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch proposal	none
same patch with main script in the body	none

Description arno. 2013-03-27 16:50:00 PDT

Hi,
since bug #106553 is fixed (and also bugs #113446 and #112475), it is now possible to use CanvasWindingRule type for winding rules.

Comment 1 arno. 2013-03-27 16:55:10 PDT

Created attachment 195436 [details]
patch proposal

Comment 2 Kentaro Hara 2013-03-27 18:01:36 PDT

Comment on attachment 195436 [details]
patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=195436&action=review

Thanks for improving WebKit IDLs. I think there would be more places we can use enum (e.g. XMLHttpRequest.responseType).

> LayoutTests/fast/canvas/winding-enumeration.html:5
> +<script>

Normally we write the main script in <body>.

<head><script src="...pre.js"></script></head>
<body>
<script>main script</script>
<script src="...post.js"></script>
</body>

Comment 3 arno. 2013-03-28 10:33:06 PDT

Created attachment 195593 [details]
same patch with main script in the body

Comment 4 Kentaro Hara 2013-03-28 10:50:26 PDT

Comment on attachment 195593 [details]
same patch with main script in the body

thanks.

Comment 5 WebKit Review Bot 2013-03-28 11:11:26 PDT

Comment on attachment 195593 [details]
same patch with main script in the body

Clearing flags on attachment: 195593

Committed r147133: <http://trac.webkit.org/changeset/147133>

Comment 6 WebKit Review Bot 2013-03-28 11:11:30 PDT

All reviewed patches have been landed.  Closing bug.