Bug 113456

Summary: use CanvasWindingRule enumeration in CanvasRenderingContext2D.idl
Product: WebKit Reporter: arno. <a.renevier>
Component: CanvasAssignee: arno. <a.renevier>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cabanier, esprehn+autocc, haraken, krit, nbarth, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch proposal
none
same patch with main script in the body none

arno.
Reported 2013-03-27 16:50:00 PDT
Hi, since bug #106553 is fixed (and also bugs #113446 and #112475), it is now possible to use CanvasWindingRule type for winding rules.
Attachments
patch proposal (5.25 KB, patch)
2013-03-27 16:55 PDT, arno. 		no flags
DetailsFormatted DiffDiff
same patch with main script in the body (5.21 KB, patch)
2013-03-28 10:33 PDT, arno. 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
arno.
Comment 1 2013-03-27 16:55:10 PDT
Created attachment 195436 [details] patch proposal
Kentaro Hara
Comment 2 2013-03-27 18:01:36 PDT
Comment on attachment 195436 [details] patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=195436&action=review Thanks for improving WebKit IDLs. I think there would be more places we can use enum (e.g. XMLHttpRequest.responseType). > LayoutTests/fast/canvas/winding-enumeration.html:5 > +<script> Normally we write the main script in <body>. <head><script src="...pre.js"></script></head> <body> <script>main script</script> <script src="...post.js"></script> </body>
arno.
Comment 3 2013-03-28 10:33:06 PDT
Created attachment 195593 [details] same patch with main script in the body
Kentaro Hara
Comment 4 2013-03-28 10:50:26 PDT
Comment on attachment 195593 [details] same patch with main script in the body thanks.
WebKit Review Bot
Comment 5 2013-03-28 11:11:26 PDT
Comment on attachment 195593 [details] same patch with main script in the body Clearing flags on attachment: 195593 Committed r147133: <http://trac.webkit.org/changeset/147133>
WebKit Review Bot
Comment 6 2013-03-28 11:11:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.