Bug 11342

Summary: fast/repaint/4774354 is failing
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, robert, timothy
Priority: P2 Keywords: LayoutTestFailure
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://build.webkit.org/results/post-commit-powerpc-mac-os-x/3887/fast/repaint/4774354-diffs.txt
Attachments:
Description Flags
New results none

Adam Roben (:aroben)
Reported 2006-10-18 00:58:39 PDT
r17094 seems to have broken fast/repaint/4774354
Attachments
New results (1.83 KB, patch)
2006-10-18 18:08 PDT, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Harrison
Comment 1 2006-10-18 08:12:08 PDT
r17094 was for <rdar://problem/4776665> REGRESSION: In Mail, caret is visible when the message body isn't focused
David Harrison
Comment 2 2006-10-18 08:14:12 PDT
The broken test is for <rdar://problem/4774354> REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body
David Harrison
Comment 3 2006-10-18 13:16:15 PDT
The detail of the failure is the addition of an empty RenderText node. The change in r17094 was strictly for the drawing of caret, and does not affect the render tree. Confirmed that backing out the patch did not result in a successful test.
Adam Roben (:aroben)
Comment 5 2006-10-18 14:05:28 PDT
Build details for those builds are here: http://build.webkit.org/post-commit-powerpc-mac-os-x/builds/3875 http://build.webkit.org/post-commit-powerpc-mac-os-x/builds/3877 As you can see, the only revisions added between those two runs were r17093 and r17094. Perhaps it was r17093 that did it?
Adam Roben (:aroben)
Comment 6 2006-10-18 18:05:11 PDT
Wow, I was too tired when triaging these failures last night. This test has been failing since its introduction. Seems like it was checked in with wrong results. This can't even really be called a regression.
Adam Roben (:aroben)
Comment 7 2006-10-18 18:08:24 PDT
Created attachment 11140 [details] New results
Maciej Stachowiak
Comment 8 2006-10-18 18:09:58 PDT
Comment on attachment 11140 [details] New results r=me
Adam Roben (:aroben)
Comment 9 2006-10-18 18:10:56 PDT
Landed as r17125.
Robert Hogan
Comment 10 2013-04-07 03:39:39 PDT
Reopening to attach new patch.
Timothy Hatcher
Comment 11 2013-04-07 05:47:17 PDT
Wrong bug?
Note You need to log in before you can comment on or make changes to this bug.