Bug 113419

Summary:

RenderBox::backgroundIsKnownToBeOpaqueInRect may be wrong for theme-painted elements

Product:

WebKit

Reporter:

Alok Priyadarshi <alokp>

Component:

Layout and Rendering

Assignee:

Alok Priyadarshi <alokp>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric, esprehn+autocc, jamesr, koivisto, ojan.autocc, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

crbug.com/223490

Attachments:

Description	Flags
Patch	simon.fraser: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64	none
Archive of layout-test-results from gce-cr-linux-08 for chromium-linux-x86_64	none

Description Alok Priyadarshi 2013-03-27 10:16:11 PDT

It is not known if theme paints the assigned background or not, in which case we should not mark such elements as opaque.

Comment 1 Alok Priyadarshi 2013-03-27 14:52:46 PDT

Created attachment 195399 [details]
Patch

Comment 2 Simon Fraser (smfr) 2013-03-27 14:59:00 PDT

Comment on attachment 195399 [details]
Patch

Did this break a real site? If so, please say so in the change log.

Comment 3 Alok Priyadarshi 2013-03-27 15:04:52 PDT

I am not aware of any real site being broken.
It breaks the example attached in the chromium bug: crbug.com/223490

Comment 4 WebKit Review Bot 2013-03-27 18:13:57 PDT

Comment on attachment 195399 [details]
Patch

Attachment 195399 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17324207

New failing tests:
compositing/contents-opaque/control-layer.html
platform/chromium/virtual/softwarecompositing/contents-opaque/control-layer.html

Comment 5 WebKit Review Bot 2013-03-27 18:14:01 PDT

Created attachment 195454 [details]
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

Comment 6 WebKit Review Bot 2013-03-27 19:13:39 PDT

Comment on attachment 195399 [details]
Patch

Attachment 195399 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17286551

New failing tests:
compositing/contents-opaque/control-layer.html
platform/chromium/virtual/softwarecompositing/contents-opaque/control-layer.html

Comment 7 WebKit Review Bot 2013-03-27 19:13:43 PDT

Created attachment 195461 [details]
Archive of layout-test-results from gce-cr-linux-08 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

Comment 8 Alok Priyadarshi 2013-03-28 10:01:22 PDT

Committed r147127: <http://trac.webkit.org/changeset/147127>