Bug 113414 – Rename Editing tests whose expectations are Mac specific

• Component: New Bugs
• Status: RESOLVED FIXED

[Claudio Saavedra]

Rename Editing tests whose expectations are Mac specific

[Claudio Saavedra]

Created attachment 195335 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 195335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195335&action=review

> LayoutTests/editing/deleting/smart-editing-disabled-mac.html:11
> +if (window.internals)
> +    internals.settings.setEditingBehavior('mac');

Why am I not seeing the diff for this?

[Claudio Saavedra]

Comment on attachment 195335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195335&action=review

>> LayoutTests/editing/deleting/smart-editing-disabled-mac.html:11
>> +    internals.settings.setEditingBehavior('mac');
> 
> Why am I not seeing the diff for this?

Because the file is being renamed from smart-editing-disabled.html ? Not sure if that's what you mean.

[Ryosuke Niwa]

(In reply to comment #3)
> (From update of attachment 195335 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=195335&action=review
> 
> >> LayoutTests/editing/deleting/smart-editing-disabled-mac.html:11
> >> +    internals.settings.setEditingBehavior('mac');
> > 
> > Why am I not seeing the diff for this?
> 
> Because the file is being renamed from smart-editing-disabled.html ? Not sure if that's what you mean.

When I do svn mv and then edit a file, I still see a diff after the file is moved. Maybe you're using git? FWIW, you can probably do a partial checkout of just LayoutTests/editing and make changes there.

[Claudio Saavedra]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 195335 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=195335&action=review
> > 
> > >> LayoutTests/editing/deleting/smart-editing-disabled-mac.html:11
> > >> +    internals.settings.setEditingBehavior('mac');
> > > 
> > > Why am I not seeing the diff for this?
> > 
> > Because the file is being renamed from smart-editing-disabled.html ? Not sure if that's what you mean.
> 
> When I do svn mv and then edit a file, I still see a diff after the file is moved. Maybe you're using git? FWIW, you can probably do a partial checkout of just LayoutTests/editing and make changes there.

Yes, it's git. But as far as I know when pushing the diff is recorded too (see http://trac.webkit.org/changeset/144883 for example, which also came from git.)

[Ryosuke Niwa]

The point was that I can't easily this patch as is. I'll try to get around to it but I have other work to do this week so you might need to wait for a while.

[Ryosuke Niwa]

Alternatively, you can ask other reviewers to review this.

[Claudio Saavedra]

git diff -M can do this. I think we should probably patch webkit-patch to use the -M modifier.

[Ryosuke Niwa]

(In reply to comment #8)
> git diff -M can do this. I think we should probably patch webkit-patch to use the -M modifier.

Makes sense.

[Claudio Saavedra]

Created attachment 195394 [details]
Patch

[Claudio Saavedra]

Comment on attachment 195394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195394&action=review

> LayoutTests/editing/style/push-down-font-styles-mac.html:9
> +<script src="script-tests/push-down-font-styles-mac.js"></script>

Seems like this is guessed wrong.

> LayoutTests/editing/style/push-down-implicit-styles-mac.html:9
> +<script src="script-tests/push-down-implicit-styles-mac.js"></script>

And here as well.

[WebKit Review Bot]

Comment on attachment 195394 [details]
Patch

Clearing flags on attachment: 195394

Committed r147035: <http://trac.webkit.org/changeset/147035>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.