Bug 113383

Summary: Explicitly set editingBehavior in some tests
Product: WebKit Reporter: Claudio Saavedra <csaavedra>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, rakuco, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 110487    
Attachments:
Description Flags
Patch
none
Patch for landing
csaavedra: commit-queue-
Patch for landing none

Description Claudio Saavedra 2013-03-27 03:16:54 PDT
Explicitly set editingBehavior in some tests
Comment 1 Claudio Saavedra 2013-03-27 03:19:21 PDT
Created attachment 195256 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-03-27 10:19:06 PDT
Comment on attachment 195256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195256&action=review

> LayoutTests/ChangeLog:66
> +        * platform/chromium-win/editing/deleting/non-smart-delete-expected.txt: Updated.
> +        * platform/efl/editing/deleting/non-smart-delete-expected.txt: Updated.
> +        * platform/gtk/editing/deleting/non-smart-delete-expected.txt: Updated.
> +        * platform/qt/editing/deleting/non-smart-delete-expected.txt: Updated.

Do these results still not match cross-paltforms ones?
Comment 3 Claudio Saavedra 2013-03-27 10:28:43 PDT
(In reply to comment #2)
> (From update of attachment 195256 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=195256&action=review
> 
> > LayoutTests/ChangeLog:66
> > +        * platform/chromium-win/editing/deleting/non-smart-delete-expected.txt: Updated.
> > +        * platform/efl/editing/deleting/non-smart-delete-expected.txt: Updated.
> > +        * platform/gtk/editing/deleting/non-smart-delete-expected.txt: Updated.
> > +        * platform/qt/editing/deleting/non-smart-delete-expected.txt: Updated.
> 
> Do these results still not match cross-paltforms ones?

Setting editingBehavior to Mac adds one emission of shouldChangeSelectedDOMRange that gets logged. This is consistent with the expectations file for Mac. The results otherwise are unchanged.
Comment 4 Ryosuke Niwa 2013-03-27 11:06:16 PDT
Comment on attachment 195256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195256&action=review

> LayoutTests/ChangeLog:12
> +        to use a non-Windows editingBehavior.

As far as I know, the behavior on Linux matches that of Windows.

> LayoutTests/editing/deleting/smart-delete-002.html:25
> +	internals.settings.setEditingBehavior('mac');

Nit: tab character and a wrong indentation.

> LayoutTests/editing/inserting/paragraph-outside-nested-divs.html:11
> +	internals.settings.setEditingBehavior("mac");

Ditto.

> LayoutTests/editing/pasteboard/drag-drop-modifies-page.html:10
> +	internals.settings.setEditingBehavior("mac");

Ditto.
Comment 5 Claudio Saavedra 2013-03-27 11:15:54 PDT
(In reply to comment #4)
> (From update of attachment 195256 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=195256&action=review
> 
> > LayoutTests/ChangeLog:12
> > +        to use a non-Windows editingBehavior.
> 
> As far as I know, the behavior on Linux matches that of Windows.
>

Thee are differences. Like what we're implementing in bug 110487. That applies only to Windows. Linux doesn't select spacing after the word.
Comment 6 Ryosuke Niwa 2013-03-27 11:26:41 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 195256 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=195256&action=review
> > 
> > > LayoutTests/ChangeLog:12
> > > +        to use a non-Windows editingBehavior.
> > 
> > As far as I know, the behavior on Linux matches that of Windows.
> >
> 
> Thee are differences. Like what we're implementing in bug 110487. That applies only to Windows. Linux doesn't select spacing after the word.

But that doesn't mean non-Windows behavior will always match in terms of word boundary movements so that phrase is imprecise to say the least. I'd much prefer explicitly saying use Mac behavior.
Comment 7 Claudio Saavedra 2013-03-27 11:34:34 PDT
Created attachment 195366 [details]
Patch for landing
Comment 8 Claudio Saavedra 2013-03-27 11:35:52 PDT
Comment on attachment 195366 [details]
Patch for landing

Weird, webkit-patch didn't update the ChangeLog reviewer.
Comment 9 Claudio Saavedra 2013-03-27 11:36:42 PDT
Created attachment 195367 [details]
Patch for landing
Comment 10 WebKit Review Bot 2013-03-27 17:31:40 PDT
Comment on attachment 195367 [details]
Patch for landing

Clearing flags on attachment: 195367

Committed r147036: <http://trac.webkit.org/changeset/147036>
Comment 11 WebKit Review Bot 2013-03-27 17:31:44 PDT
All reviewed patches have been landed.  Closing bug.