Bug 113382

Summary: [EFL][WK2] Empty tooltip shown when hovering over popup menu items
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Sudarsana Nagineni (babu) 2013-03-27 03:05:40 PDT 
Useless empty tooltip box shown when hovering over popup menu items.
Comment 1 Sudarsana Nagineni (babu) 2013-03-27 05:13:55 PDT 
Created attachment 195284 [details]
Patch
Comment 2 Gyuyoung Kim 2013-04-02 01:11:56 PDT 
Comment on attachment 195284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195284&action=review

> Tools/MiniBrowser/efl/main.c:932
> +                const char* tooltipText = ewk_popup_menu_item_tooltip_get(ewk_item);

Wrong * place. And, please follow EFL variable name style in MiniBrowser, tooltip_text ?
Comment 3 Sudarsana Nagineni (babu) 2013-04-02 01:23:30 PDT 
Created attachment 196100 [details]
Patch

Take Gyuyoung's feedback into consideration.
Comment 4 Chris Dumez 2013-04-02 01:24:12 PDT 
Comment on attachment 196100 [details]
Patch

LGTM. Thanks.
Comment 5 Gyuyoung Kim 2013-04-02 01:54:24 PDT 
Comment on attachment 196100 [details]
Patch

Chrome and Safari browsers also don't show tooltip box when tooltip text is null. So, this patch allows MiniBrowser to follow their behavior. LGTM.
Comment 6 WebKit Review Bot 2013-04-02 02:48:34 PDT 
Comment on attachment 196100 [details]
Patch

Clearing flags on attachment: 196100

Committed r147410: <http://trac.webkit.org/changeset/147410>
Comment 7 WebKit Review Bot 2013-04-02 02:48:38 PDT 
All reviewed patches have been landed.  Closing bug.