Summary: | Web Inspector: [Settings] "previouslyViewedFiles" exceeds local storage quota. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eugene Klyuchnikov <eustas> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Eugene Klyuchnikov <eustas> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Eugene Klyuchnikov
2013-03-27 01:57:59 PDT
One more thing to fix: history log is unlimited. Created attachment 195257 [details]
Patch
Comment on attachment 195257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195257&action=review > Source/WebCore/inspector/front-end/TabbedEditorContainer.js:601 > + if (serializedHistory.length === WebInspector.TabbedEditorContainer.maximalPreviouslyViewedFilesCount) What if it already was larger than maximum? (This also needs a test) Comment on attachment 195257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195257&action=review >> Source/WebCore/inspector/front-end/TabbedEditorContainer.js:601 >> + if (serializedHistory.length === WebInspector.TabbedEditorContainer.maximalPreviouslyViewedFilesCount) > > What if it already was larger than maximum? serializedHistory is initially clear and we add at most one item per loop. So this is possible only in if maximalPreviouslyViewedFilesCount <= 0. Comment on attachment 195257 [details] Patch Clearing flags on attachment: 195257 Committed r147104: <http://trac.webkit.org/changeset/147104> All reviewed patches have been landed. Closing bug. |