Bug 113371

Summary:

Web Inspector: Timeline. Refresh is slow when user drags the overview window.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, buildbot, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	pfeldman: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-07 for mac-future	none

Ilya Tikhonovsky

Reported 2013-03-27 01:16:01 PDT

We are postpone the refresh to 300ms if it is not a scroll event. I think we can use smaller timeout if the user drags the overview window and timeline is not in the recording mode. patch to follow.

Attachments
Patch (1.60 KB, patch) 2013-03-27 01:18 PDT, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
Patch (7.20 KB, patch) 2013-03-27 04:46 PDT, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
Patch (7.22 KB, patch) 2013-03-27 04:50 PDT, Ilya Tikhonovsky	pfeldman: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-07 for mac-future (1.23 MB, application/zip) 2013-03-27 18:33 PDT, Build Bot	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2013-03-27 01:18:15 PDT

Created attachment 195238 [details] Patch

Pavel Feldman

Comment 2 2013-03-27 01:20:14 PDT

Comment on attachment 195238 [details] Patch Why do we use _scheduleRefresh at all?

Ilya Tikhonovsky

Comment 3 2013-03-27 04:46:46 PDT

Created attachment 195275 [details] Patch

Ilya Tikhonovsky

Comment 4 2013-03-27 04:50:29 PDT

Created attachment 195277 [details] Patch

Pavel Feldman

Comment 5 2013-03-27 07:25:54 PDT

Comment on attachment 195277 [details] Patch I would strongly advise to invert the flag and call it "userGesture"

Build Bot

Comment 6 2013-03-27 18:33:08 PDT

Comment on attachment 195277 [details] Patch Attachment 195277 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17235739 New failing tests: media/video-zoom.html animations/combo-transform-translate+scale.html

Build Bot

Comment 7 2013-03-27 18:33:10 PDT

Created attachment 195455 [details] Archive of layout-test-results from webkit-ews-07 for mac-future The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-future Platform: Mac OS X 10.8.2

Ilya Tikhonovsky

Comment 8 2013-03-28 00:39:01 PDT

Committed r147076: <http://trac.webkit.org/changeset/147076>

Note You need to log in before you can comment on or make changes to this bug.