Bug 113371

Summary: Web Inspector: Timeline. Refresh is slow when user drags the overview window.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, buildbot, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
pfeldman: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-07 for mac-future none

Description Ilya Tikhonovsky 2013-03-27 01:16:01 PDT 
We are postpone the refresh to 300ms if it is not a scroll event.
I think we can use smaller timeout if the user drags the overview window and timeline is not in the recording mode.

patch to follow.
Comment 1 Ilya Tikhonovsky 2013-03-27 01:18:15 PDT 
Created attachment 195238 [details]
Patch
Comment 2 Pavel Feldman 2013-03-27 01:20:14 PDT 
Comment on attachment 195238 [details]
Patch

Why do we use _scheduleRefresh at all?
Comment 3 Ilya Tikhonovsky 2013-03-27 04:46:46 PDT 
Created attachment 195275 [details]
Patch
Comment 4 Ilya Tikhonovsky 2013-03-27 04:50:29 PDT 
Created attachment 195277 [details]
Patch
Comment 5 Pavel Feldman 2013-03-27 07:25:54 PDT 
Comment on attachment 195277 [details]
Patch

I would strongly advise to invert the flag and call it "userGesture"
Comment 6 Build Bot 2013-03-27 18:33:08 PDT 
Comment on attachment 195277 [details]
Patch

Attachment 195277 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17235739

New failing tests:
media/video-zoom.html
animations/combo-transform-translate+scale.html
Comment 7 Build Bot 2013-03-27 18:33:10 PDT 
Created attachment 195455 [details]
Archive of layout-test-results from webkit-ews-07 for mac-future

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-future  Platform: Mac OS X 10.8.2
Comment 8 Ilya Tikhonovsky 2013-03-28 00:39:01 PDT 
Committed r147076: <http://trac.webkit.org/changeset/147076>