Bug 113365 – Indicate external texture layer that whether canvas is a single buffer user

• Component: Canvas
• Status: RESOLVED INVALID

[KangYuan]

Hopefully this could improve performance for chromium.

[KangYuan]

Created attachment 195228 [details]
Patch

[KangYuan]

I post my cl here

https://bugs.webkit.org/show_bug.cgi?id=113365
https://codereview.chromium.org/12720022/

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 195228 [details]
Patch

Attachment 195228 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17320188

[Peter Beverloo (cr-android ews)]

Comment on attachment 195228 [details]
Patch

Attachment 195228 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17216911

[WebKit Review Bot]

Comment on attachment 195228 [details]
Patch

Attachment 195228 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17231635

[KangYuan]

Created attachment 195232 [details]
Patch

[WebKit Review Bot]

Comment on attachment 195232 [details]
Patch

Attachment 195232 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17209973

New failing tests:
compositing/overflow/image-load-overflow-scrollbars.html
compositing/webgl/webgl-nonpremultiplied-blend.html
fast/canvas/webgl/constants.html
http/tests/cache/subresource-failover-to-network.html
fast/canvas/webgl/functions-returning-strings.html
compositing/visibility/visibility-simple-canvas2d-layer.html
fast/canvas/webgl/gl-enable-enum-test.html
compositing/webgl/webgl-repaint.html
fast/canvas/webgl/context-release-upon-reload.html
compositing/layer-creation/spanOverlapsCanvas.html
fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html
fast/canvas/webgl/gl-get-calls.html
http/tests/canvas/webgl/origin-clean-conformance.html
compositing/visibility/visibility-simple-webgl-layer.html
compositing/webgl/webgl-background-color.html
fast/canvas/webgl/canvas-test.html
compositing/masks/layer-mask-placement.html
fast/canvas/webgl/canvas-resize-crash.html
fast/canvas/webgl/gl-bind-attrib-location-test.html
fast/canvas/webgl/framebuffer-test.html
compositing/overflow/overflow-hidden-canvas-layer.html
fast/canvas/webgl/context-lost.html
fast/canvas/webgl/attrib-location-length-limits.html
compositing/webgl/webgl-no-alpha.html
compositing/webgl/webgl-reflection.html
fast/canvas/webgl/gl-enum-tests.html
fast/canvas/webgl/array-bounds-clamping.html
fast/canvas/webgl/canvas-2d-webgl-texture.html
fast/canvas/webgl/gl-getshadersource.html
compositing/backface-visibility/backface-visibility-webgl.html

[WebKit Review Bot]

Created attachment 195242 [details]
Archive of layout-test-results from gce-cr-linux-07 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[KangYuan]

chromium test fail because the bot didn't apply chromium patch. I don't how to deal with that. sorry for that...

[James Robinson]

How do you expect this to be used?

[Brent Fulgham]

Closing Chromium-specific change now that they are no longer here.

[Brent Fulgham]

Comment on attachment 195232 [details]
Patch

Clearing flag for discarded change.