Bug 113360

Summary:

[GTK] [gyp] Improve support for rerunning gyp automatically

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

WebKitGTK

Assignee:

Martin Robinson <mrobinson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	gustavo: review+

Description Martin Robinson 2013-03-26 18:18:02 PDT

When the gyp files change, the build should rerun gyp automatically. Because of bugs in gyp, this is broken. The suggestion on the gyp list was to simply write this ourselves.

Comment 1 Martin Robinson 2013-03-26 18:54:18 PDT

Created attachment 195206 [details]
Patch

Comment 2 Gustavo Noronha (kov) 2013-03-27 16:20:59 PDT

Comment on attachment 195206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195206&action=review

> Source/WebKit/gtk/gyp/GNUmakefile:16
> +	@echo "Rerunning gyp..." && ./run-gyp

&& here is unnecessary I'd say, there is no way for echo to fail, is there? ; should do, but that's just a nit

> Source/WebKit/gtk/gyp/autogen.sh:19
> +    ln -s "$SCRIPT_DIRECTORY/GNUmakefile"

Just thinking out loud here: I'm wondering after rereading this if we shouldn't just ln -sf, guess that can break if $SCRIPT_DIRECTORY == ., hrm

Comment 3 Martin Robinson 2013-03-28 09:38:45 PDT

Committed r147125: <http://trac.webkit.org/changeset/147125>