Summary: | Mac: Media Controls always hide time display elements | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cbiesinger, dglazkov, eric.carlson, eric, esprehn+autocc, feature-media-reviews, macpherson, menard, ojan.autocc, ojan, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Jer Noble
2013-03-26 16:57:16 PDT
Created attachment 195204 [details]
Patch
Comment on attachment 195204 [details] Patch Attachment 195204 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17258578 New failing tests: media/media-document-audio-repaint.html media/video-no-audio.html media/controls-strict.html media/controls-styling.html media/video-display-toggle.html media/controls-styling-strict.html media/audio-repaint.html media/audio-controls-rendering.html media/video-zoom-controls.html fast/hidpi/video-controls-in-hidpi.html media/video-controls-rendering.html media/controls-without-preload.html platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi.html media/media-controls-clone.html fast/layers/video-layer.html media/track/track-cue-rendering-vertical.html media/video-empty-source.html media/video-playing-and-pause.html media/track/track-cue-rendering-horizontal.html media/controls-after-reload.html Created attachment 195208 [details]
Archive of layout-test-results from gce-cr-linux-01 for chromium-linux-x86_64
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Created attachment 195227 [details]
Patch
Made the time display elements back into flexboxes on Chromium.
Committed r146992: <http://trac.webkit.org/changeset/146992> (cc ojan, fyi the fix for the audio controls) |