Bug 113350

Summary: IndexedDB: Histogram cause of LevelDB write errors
Product: WebKit Reporter: David Grogan <dgrogan>
Component: New BugsAssignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, jsbell, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description David Grogan 2013-03-26 15:59:12 PDT
IndexedDB: Histogram cause of LevelDB write errors
Comment 1 David Grogan 2013-03-26 16:02:21 PDT
Created attachment 195178 [details]
Patch
Comment 2 David Grogan 2013-03-26 16:03:49 PDT
Josh/Alec, could one of you review this?
Comment 3 Joshua Bell 2013-03-26 16:18:55 PDT
Comment on attachment 195178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195178&action=review

lgtm...

> Source/WebCore/ChangeLog:8
> +        If write errors are caused by IO errors then our attempts to fix open

It took me a few reads to parse this, and I'm still confused by the comment. Do you mean: distinguish write errors caused by IO from write errors caused by corruption?

I'd just describe the change: add histogram for source of leveldb errors on Write in addition to Open.
Comment 4 David Grogan 2013-03-26 16:22:06 PDT
Comment on attachment 195178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195178&action=review

>> Source/WebCore/ChangeLog:8
>> +        If write errors are caused by IO errors then our attempts to fix open
> 
> It took me a few reads to parse this, and I'm still confused by the comment. Do you mean: distinguish write errors caused by IO from write errors caused by corruption?
> 
> I'd just describe the change: add histogram for source of leveldb errors on Write in addition to Open.

Changed.

That is indeed what I meant.
Comment 5 David Grogan 2013-03-26 16:22:21 PDT
Created attachment 195183 [details]
Patch
Comment 6 David Grogan 2013-03-26 16:23:26 PDT
Tony, could you review this?
Comment 7 WebKit Review Bot 2013-03-26 17:15:02 PDT
Comment on attachment 195183 [details]
Patch

Clearing flags on attachment: 195183

Committed r146950: <http://trac.webkit.org/changeset/146950>
Comment 8 WebKit Review Bot 2013-03-26 17:15:05 PDT
All reviewed patches have been landed.  Closing bug.