Bug 113309

Summary: FormData::deepCopy() could use Vector::uncheckedAppend()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, laszlo.gombos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2013-03-26 07:22:27 PDT
FormData::deepCopy() currently calls reserveInitialCapacity() on the Vector but then uses the regular append() method. We could use uncheckedAppend() instead and bypass capacity checks since we already know the capacity is sufficient.
Attachments
Patch (2.72 KB, patch)
2013-03-26 07:26 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-03-26 07:26:10 PDT
Created attachment 195084 [details] Patch
WebKit Review Bot
Comment 2 2013-03-26 08:20:15 PDT
Comment on attachment 195084 [details] Patch Clearing flags on attachment: 195084 Committed r146884: <http://trac.webkit.org/changeset/146884>
WebKit Review Bot
Comment 3 2013-03-26 08:20:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.