Summary: | SocketStreamHandle (Chromium port) should fully use IPC window in send() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Takeshi Yoshino <tyoshino> | ||||||
Component: | WebCore Misc. | Assignee: | Takeshi Yoshino <tyoshino> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ricea, tkent, toyoshim, webkit.review.bot, yhirano | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Takeshi Yoshino
2013-03-26 06:26:58 PDT
Created attachment 195075 [details]
Patch
Comment on attachment 195075 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195075&action=review I agree with this change. > Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp:80 > if (m_pendingAmountSent + len >= m_maxPendingSendAllowed) Nits: Now, this condition can be '>' instead of '>='. +tkent for sanctifying to land this change. Created attachment 195212 [details]
Patch
Thanks for review, Takashi. (In reply to comment #2) > Nits: Now, this condition can be '>' instead of '>='. done Comment on attachment 195212 [details]
Patch
Looks ok
Comment on attachment 195212 [details] Patch Clearing flags on attachment: 195212 Committed r146965: <http://trac.webkit.org/changeset/146965> All reviewed patches have been landed. Closing bug. |