Bug 113302

Summary:

Remove ResourceLoadInfo

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, beidson, benjamin, eric, japhet, koivisto, laszlo.gombos, rniwa, sam, schenney, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Cleanup	benjamin: review+

Chris Dumez

Reported 2013-03-26 06:09:14 PDT

The ResourceLoadInfo class has been there for a long time but is still only used by Chromium port. However, the code using ResourceLoadInfo (and ResourceLoadInfo class itself) is compiled for all the ports. We could move ResourceLoadInfo class to platform/network/chromium folder, and move the related getters / setters from ResourceResponseBase to Chromium's ResourceResponse. There seems to be no point compiling this code for other ports at the moment.

Attachments
Patch (21.04 KB, patch) 2013-03-26 06:36 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Cleanup (16.38 KB, patch) 2013-04-11 17:04 PDT, Ryosuke Niwa	benjamin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2013-03-26 06:36:59 PDT

Created attachment 195076 [details] Patch

Adam Barth

Comment 2 2013-03-30 11:26:45 PDT

Comment on attachment 195076 [details] Patch I don't see the benefit of this change.

Ryosuke Niwa

Comment 3 2013-04-08 17:21:51 PDT

Now that Chromium port no longer exists, we should just remove ResourceLoadInfo.

Ryosuke Niwa

Comment 4 2013-04-11 17:04:03 PDT

Created attachment 197700 [details] Cleanup

Benjamin Poulain

Comment 5 2013-04-11 17:07:31 PDT

Comment on attachment 197700 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=197700&action=review > Source/WebCore/inspector/InspectorResourceAgent.cpp:152 > + String statusText = response.httpStatusText(); const String& statusText

Ryosuke Niwa

Comment 6 2013-04-11 17:10:03 PDT

Comment on attachment 197700 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=197700&action=review >> Source/WebCore/inspector/InspectorResourceAgent.cpp:152 >> + String statusText = response.httpStatusText(); > > const String& statusText I've removed this local variable and directly called response.httpStatusText() when we call setHeaders.

Ryosuke Niwa

Comment 7 2013-04-11 17:49:16 PDT

Committed r148256: <http://trac.webkit.org/changeset/148256>

Note You need to log in before you can comment on or make changes to this bug.