Summary: | REGRESSION(r145279): Build fails while linking when MEDIA_STREAM is enabled | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, berto, commit-queue, gyuyoung.kim, haraken, hta, rakuco, tommyw, webkit-ews, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | Regression | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 111729 | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2013-03-26 04:21:40 PDT
Created attachment 195056 [details]
Patch
Comment on attachment 195056 [details] Patch Attachment 195056 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17197985 Comment on attachment 195056 [details] Patch Attachment 195056 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17316108 (In reply to comment #2) > (From update of attachment 195056 [details]) > Attachment 195056 [details] did not pass qt-wk2-ews (qt): > Output: http://webkit-commit-queue.appspot.com/results/17197985 It seems JSRTCStatsResponse.h is not generated when media stream is disabled, so I guess I just need to move the include inside the #if ENABLE(MEDIA_STREAM) block (In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 195056 [details] [details]) > > Attachment 195056 [details] [details] did not pass qt-wk2-ews (qt): > > Output: http://webkit-commit-queue.appspot.com/results/17197985 > > It seems JSRTCStatsResponse.h is not generated when media stream is disabled, so I guess I just need to move the include inside the #if ENABLE(MEDIA_STREAM) block Could someone from qt confirm this? Maybe I should not include the JSRTCStatsResponseCustom.cpp file to the compilation for qt. Patch seems clean to me, but seems to address a symptom, not the cause. Does this mean that the [NamedGetter] modifier can only be used with custom bindings for JSC? If so, that seems like a problem with the implementation of NamedGetter. Are there test cases one could build for this, so that it gets detected earlier (either add NamedGetter to the test set for the JSC compiler, or add a target that compiles MediaStream with JSC and runs on the bots)? (In reply to comment #6) > Patch seems clean to me, but seems to address a symptom, not the cause. > > Does this mean that the [NamedGetter] modifier can only be used with custom bindings for JSC? I seems so, see all other JS*Custom files in bindings/js/ Created attachment 195131 [details]
Try to fix qt build
Comment on attachment 195131 [details]
Try to fix qt build
Since this is a build fix I think it makes sense to push it now. I agree that possibly the bindings generator should cope with this somehow (but I'm not an expert, so perhaps there are good reasons for this), but we can fix it after this patch lands. Also a BlackBerry EWS/buildbot is planned, so we should be able to catch this stuff in the near future.
Comment on attachment 195131 [details]
Try to fix qt build
Thanks!
Comment on attachment 195131 [details] Try to fix qt build Clearing flags on attachment: 195131 Committed r147731: <http://trac.webkit.org/changeset/147731> All reviewed patches have been landed. Closing bug. |