Bug 113275 – [shadow] styleForText should consider the case where parent node has no style

• Component: CSS
• Status: RESOLVED FIXED

[Takashi Sakamoto]

Created attachment 195004 [details]
repro.html

If some text node is distributed to an insertion point but the parent of the insertion point
is out of composition, the text node's parent for rendering and styling might has no style.

For example, firstly create the following DOM tree:

   div1 --- shadow1 ---- shadow2
               |            |
               +---text     +---div2 ---- shadow3
                            |
                            |
                            |
                            |
                            |
                            +---shadow

Now insert [div3 -- shadow] under div2:


   div1 --- shadow1 ---- shadow2
               |            |
               +---text     +---div2 ---- shadow3
                            |     |
                            |     +-----div3
                            |             |
                            |             +----shadow
                            |
                            +---shadow

c.f. https://cluster-fuzz.appspot.com/testcase?key=163551153

[Takashi Sakamoto]

div3 is a parent for rendering and styling of text and is out of composition.
So div3->renderStyle() would return 0.

[Takashi Sakamoto]

Created attachment 195007 [details]
Patch

[Build Bot]

Comment on attachment 195007 [details]
Patch

Attachment 195007 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17184780

[Hajime Morrita]

Comment on attachment 195007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195007&action=review

> LayoutTests/fast/dom/shadow/text-node-distributed-crash.html:31
> +function runTest() {

You could use Hayato-san's createDOM() helper to make it readable without comments.

[Takashi Sakamoto]

Created attachment 195220 [details]
Patch

[Takashi Sakamoto]

Comment on attachment 195007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195007&action=review

Thank you for reviewing.

>> LayoutTests/fast/dom/shadow/text-node-distributed-crash.html:31
>> +function runTest() {
> 
> You could use Hayato-san's createDOM() helper to make it readable without comments.

Sure. Done.

[Hajime Morrita]

Comment on attachment 195220 [details]
Patch

Let's land after seeing a green win.

[WebKit Review Bot]

Comment on attachment 195220 [details]
Patch

Clearing flags on attachment: 195220

Committed r146967: <http://trac.webkit.org/changeset/146967>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.