Summary: | [shadow] styleForText should consider the case where parent node has no style | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Takashi Sakamoto <tasak> | ||||||||
Component: | CSS | Assignee: | Takashi Sakamoto <tasak> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | allan.jensen, esprehn+autocc, macpherson, menard, ojan.autocc, webcomponents-bugzilla, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 59827 | ||||||||||
Attachments: |
|
Description
Takashi Sakamoto
2013-03-25 22:23:05 PDT
div3 is a parent for rendering and styling of text and is out of composition. So div3->renderStyle() would return 0. Created attachment 195007 [details]
Patch
Comment on attachment 195007 [details] Patch Attachment 195007 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17184780 Comment on attachment 195007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195007&action=review > LayoutTests/fast/dom/shadow/text-node-distributed-crash.html:31 > +function runTest() { You could use Hayato-san's createDOM() helper to make it readable without comments. Created attachment 195220 [details]
Patch
Comment on attachment 195007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195007&action=review Thank you for reviewing. >> LayoutTests/fast/dom/shadow/text-node-distributed-crash.html:31 >> +function runTest() { > > You could use Hayato-san's createDOM() helper to make it readable without comments. Sure. Done. Comment on attachment 195220 [details]
Patch
Let's land after seeing a green win.
Comment on attachment 195220 [details] Patch Clearing flags on attachment: 195220 Committed r146967: <http://trac.webkit.org/changeset/146967> All reviewed patches have been landed. Closing bug. |