Summary: | [BlackBerry] Populate the mime type of the WebContext for images | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Arvid Nilsson <anilsson> | ||||||
Component: | WebKit BlackBerry | Assignee: | Arvid Nilsson <anilsson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | anilsson, jpetsovits, jrogers, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Arvid Nilsson
2013-03-25 21:13:25 PDT
Created attachment 194994 [details]
Patch
Comment on attachment 194994 [details]
Patch
This looks really hacky. Is this the best way to achieve this result?
(In reply to comment #2) > (From update of attachment 194994 [details]) > This looks really hacky. Is this the best way to achieve this result? My thinking is that this is better than using the one in ResourceResponse, because the server could be misconfigured and report broken or no mime type. So even though context.setMimetype(cachedImage->response().mimeType()) is a lot less code, I'm worried it's less reliable. (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 194994 [details] [details]) > > This looks really hacky. Is this the best way to achieve this result? > > My thinking is that this is better than using the one in ResourceResponse, because the server could be misconfigured and report broken or no mime type. Shouldn't we take the server-issued one if it is issued, and if not, then try to put our own in? (In reply to comment #5) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 194994 [details] [details] [details]) > > > This looks really hacky. Is this the best way to achieve this result? > > > > My thinking is that this is better than using the one in ResourceResponse, because the server could be misconfigured and report broken or no mime type. > > Shouldn't we take the server-issued one if it is issued, and if not, then try to put our own in? I had it that way originally, let me put it back in =) Created attachment 195125 [details]
Patch
Comment on attachment 195125 [details]
Patch
Thanks, George =)
Comment on attachment 195125 [details] Patch Clearing flags on attachment: 195125 Committed r147024: <http://trac.webkit.org/changeset/147024> All reviewed patches have been landed. Closing bug. |