Summary: | Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Graham Dennis <Graham.Dennis> | ||||||
Component: | HTML Editing | Assignee: | Graham Dennis <Graham.Dennis> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dwood, justin.garcia | ||||||
Priority: | P2 | ||||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
Graham Dennis
2006-10-17 02:24:27 PDT
Created attachment 11128 [details] patch This patch modifies the UI delegate so that it can be tested without writing a wrapper application. Other changes include clearing the *OnMouseDown variables in HTMLAnchorElement (see bug 10338) on mouseenter and not mouseout. This is because the values of these variables are needed for drag operations but these happen after mouseout events. It shouldn't be necessary to clear these variables at all because they are only accessed on a mouse click or mouse drag event, both of which happen after a mousedown event. But I figure it's best to clear them for safety anyway. I'm not sure that it is possible to test this automatically, so I've just modified the description for the contenteditable-link.html manual test to describe these changes. I added the WebElementLinkIsLiveKey to the WebElementDictionary so that WebHTMLView can determine whether or not a link is 'live', and so if it is draggable. Comment on attachment 11128 [details]
patch
We can't modify WebKit/WebView/WebView.h, since the API would need to be reviewed. Is WebElementLinkIsLiveKey needed to fix this? Also this has some bit rot, WebElementDictionary has moved/changed.
Created attachment 11391 [details]
patch 2
Updated patch fixing patch rot and other issues.
I'm honestly not sure what I was thinking when I changed WebView.h, I should have modified WebViewPrivate.h instead... This patch fixes that and extends WebCore's HitTestResult to provide the info for the WebElementDictionary. As a result, the isLiveLink method doesn't need to be exported by the *.idl file like it was in the previous patch.
|