Bug 113223

Summary: REGRESSION(r146657): Test failures reported incorrectly
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, kadam, rniwa, webkit.review.bot, zarvai
Priority: P2 Keywords: NRWT
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 112898    
Attachments:
Description Flags
Fixes the bug dpranke: review+, buildbot: commit-queue-

Csaba Osztrogonác
Reported 2013-03-25 10:58:41 PDT
After http://trac.webkit.org/changeset/146657 simple test failures reported incorrectly by NRWT and buildbot. Here is a simple example: css3/filters/effect-reference.html was broken by http://trac.webkit.org/changeset/146779. (It seems it needs only rebaseline.) But the problem is the following NRWT output: ... 09:52:43.778 10859 [4003/28958] css3/filters/effect-reference.html failed unexpectedly (text diff) 09:52:43.778 10859 worker/0 css3/filters/effect-reference.html failed: 09:52:43.778 10859 worker/0 text diff ... 10:11:28.026 10859 Retrying 6 unexpected failure(s) ... ... 10:20:17.156 10859 [4/6] css3/filters/effect-reference.html failed unexpectedly (text diff, image diff) 10:20:17.156 10859 worker/0 css3/filters/effect-reference.html failed: 10:20:17.157 10859 worker/0 text diff 10:20:17.157 10859 worker/0 image diff ... 10:20:27.659 10859 Testing completed, Exit status: 1 <-------- correct exit code ... Unexpected flakiness: text-only failures (4) css3/filters/effect-reference.html [ Failure Pass Failure ] <------ This line is absolutely wrong! ... and the reported result by the bot: (It is wrong, because its input is wrong) 9 new passes 6 flakes 7 missing results See http://build.webkit.org/builders/Qt%20Linux%20Release/builds/58743 for details
Attachments
Fixes the bug (25.60 KB, patch)
2013-03-25 13:28 PDT, Ryosuke Niwa
dpranke: review+
buildbot: commit-queue-
Ryosuke Niwa
Comment 1 2013-03-25 13:28:22 PDT
Created attachment 194912 [details] Fixes the bug
Build Bot
Comment 2 2013-03-25 14:48:05 PDT
Ryosuke Niwa
Comment 3 2013-03-25 15:10:51 PDT
Note You need to log in before you can comment on or make changes to this bug.