Bug 11322

Summary:

move-js-headers.sh causes unnecessary source rebuilds

Product:

WebKit

Reporter:

Kevin Ollivier <kevino>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mrowe

Priority:

Version:

420+

Hardware:

All

OS:

All

Attachments:

Description	Flags
Preserve original modification time for copied headers.	ggaren: review+

Kevin Ollivier

Reported 2006-10-16 19:12:15 PDT

Since the cp operation in move-js-headers.sh does not use the -p option to preserve the modification time of the original file, make thinks that all the headers in WebCore/include/JavaScriptCore have been modified since the last build, and thus forces a rebuild of all sources that depend on them. The attached patch adds the -p option to stop this from happening.

Attachments
Preserve original modification time for copied headers. (1.03 KB, patch) 2006-10-16 19:14 PDT, Kevin Ollivier	ggaren: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kevin Ollivier

Comment 1 2006-10-16 19:14:09 PDT

Created attachment 11122 [details] Preserve original modification time for copied headers.

Geoffrey Garen

Comment 2 2006-10-17 11:26:34 PDT

Comment on attachment 11122 [details] Preserve original modification time for copied headers. r=me

Anders Carlsson

Comment 3 2006-11-02 19:34:58 PST

Committed revision 17557.

Note You need to log in before you can comment on or make changes to this bug.