Bug 113219

Summary: javascriptcore bindings do not check exception after calling valueToStringWithNullCheck
Product: WebKit Reporter: arno. <a.renevier>
Component: WebCore JavaScriptAssignee: arno. <a.renevier>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, dglazkov, dgrogan, ggaren, haraken, japhet, jsbell, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
testcase: name is "" with JavascriptCore, "select" with other browsers
none
testcase
none
patch proposal
none
Archive of layout-test-results from gce-cr-linux-06 for chromium-linux-x86_64
none
updated patch: add a failure expectation for chromium none

Description arno. 2013-03-25 10:28:53 PDT
Created attachment 194883 [details]
testcase: name is "" with JavascriptCore, "select" with other browsers

Hi,
JavascriptCore bindings do not check for exceptions after calling valueToStringWithNullCheck
Comment 1 arno. 2013-03-27 10:37:21 PDT
Created attachment 195348 [details]
testcase

testcase was incorrect
Comment 2 arno. 2013-03-27 14:09:35 PDT
Created attachment 195392 [details]
patch proposal

This patch also fixes #113218 for JavaScriptCore
Comment 3 WebKit Review Bot 2013-03-27 15:20:12 PDT
Comment on attachment 195392 [details]
patch proposal

Attachment 195392 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17240627

New failing tests:
fast/dom/exception-in-binding.html
Comment 4 WebKit Review Bot 2013-03-27 15:20:16 PDT
Created attachment 195412 [details]
Archive of layout-test-results from gce-cr-linux-06 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 5 arno. 2013-03-27 16:28:17 PDT
Created attachment 195429 [details]
updated patch: add a failure expectation for chromium
Comment 6 WebKit Review Bot 2013-03-27 17:39:34 PDT
Comment on attachment 195429 [details]
updated patch: add a failure expectation for chromium

Clearing flags on attachment: 195429

Committed r147038: <http://trac.webkit.org/changeset/147038>
Comment 7 WebKit Review Bot 2013-03-27 17:39:38 PDT
All reviewed patches have been landed.  Closing bug.