Bug 113219

Summary:

javascriptcore bindings do not check exception after calling valueToStringWithNullCheck

Product:

WebKit

Reporter:

arno. <a.renevier>

Component:

WebCore JavaScript

Assignee:

arno. <a.renevier>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, alecflett, dglazkov, dgrogan, ggaren, haraken, japhet, jsbell, oliver, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
testcase: name is "" with JavascriptCore, "select" with other browsers	none
testcase	none
patch proposal	none
Archive of layout-test-results from gce-cr-linux-06 for chromium-linux-x86_64	none
updated patch: add a failure expectation for chromium	none

arno.

Reported 2013-03-25 10:28:53 PDT

Created attachment 194883 [details] testcase: name is "" with JavascriptCore, "select" with other browsers Hi, JavascriptCore bindings do not check for exceptions after calling valueToStringWithNullCheck

Attachments
testcase: name is "" with JavascriptCore, "select" with other browsers (926 bytes, text/html) 2013-03-25 10:28 PDT, arno.	no flags	Details
testcase (917 bytes, text/html) 2013-03-27 10:37 PDT, arno.	no flags	Details
patch proposal (43.31 KB, patch) 2013-03-27 14:09 PDT, arno.	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-06 for chromium-linux-x86_64 (9.68 MB, application/zip) 2013-03-27 15:20 PDT, WebKit Review Bot	no flags	Details
updated patch: add a failure expectation for chromium (44.04 KB, patch) 2013-03-27 16:28 PDT, arno.	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

arno.

Comment 1 2013-03-27 10:37:21 PDT

Created attachment 195348 [details] testcase testcase was incorrect

arno.

Comment 2 2013-03-27 14:09:35 PDT

Created attachment 195392 [details] patch proposal This patch also fixes #113218 for JavaScriptCore

WebKit Review Bot

Comment 3 2013-03-27 15:20:12 PDT

Comment on attachment 195392 [details] patch proposal Attachment 195392 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17240627 New failing tests: fast/dom/exception-in-binding.html

WebKit Review Bot

Comment 4 2013-03-27 15:20:16 PDT

Created attachment 195412 [details] Archive of layout-test-results from gce-cr-linux-06 for chromium-linux-x86_64 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

arno.

Comment 5 2013-03-27 16:28:17 PDT

Created attachment 195429 [details] updated patch: add a failure expectation for chromium

WebKit Review Bot

Comment 6 2013-03-27 17:39:34 PDT

Comment on attachment 195429 [details] updated patch: add a failure expectation for chromium Clearing flags on attachment: 195429 Committed r147038: <http://trac.webkit.org/changeset/147038>

WebKit Review Bot

Comment 7 2013-03-27 17:39:38 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.