Summary: | [V8] exceptions are not checked after toInt32 calls in bindings. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | arno. <a.renevier> | ||||||
Component: | WebCore JavaScript | Assignee: | arno. <a.renevier> | ||||||
Status: | RESOLVED INVALID | ||||||||
Severity: | Normal | CC: | ggaren, haraken, oliver, simon.fraser, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 113538 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Created attachment 195619 [details]
patch proposal: fixes the problem in v8 bindings
Comment on attachment 195619 [details]
patch proposal: fixes the problem in v8 bindings
great
Comment on attachment 195619 [details] patch proposal: fixes the problem in v8 bindings Clearing flags on attachment: 195619 Committed r147149: <http://trac.webkit.org/changeset/147149> All reviewed patches have been landed. Closing bug. This broke binding generation tests on Mac: http://build.webkit.org/builders/Apple%20Lion%20Release%20WK1%20%28Tests%29/builds/10946/steps/bindings-generation-tests/logs/stdio Why is Mac code seeing a macro call V8TRYCATCH_VOID ? (In reply to comment #5) > This broke binding generation tests on Mac: > http://build.webkit.org/builders/Apple%20Lion%20Release%20WK1%20%28Tests%29/builds/10946/steps/bindings-generation-tests/logs/stdio > > Why is Mac code seeing a macro call V8TRYCATCH_VOID ? Oups, I forgot to run run-bindings-tests --reset-results. What's the best way to handle that ? Submit a patch with just test results reseted, or resubmit the commited patch with the results reseted ? Re-opened since this is blocked by bug 113538 Would you re-upload a patch with binding-tests update? (In reply to comment #8) > Would you re-upload a patch with binding-tests update? It's already been fixed in bug #113538 Ah, makes sense. Thanks! Closing some V8-related work items. |
Created attachment 194882 [details] testcase: selectedIndex will be 2 with v8/javascript; 1 in gecko and -1 in ie Hi, in generated bindings, some values are converted to integers with toInt32. exceptions are not checked afterwards. But exceptions may occur if argument is an object with an valueOf method.