| Summary: | Web Inspector: refactor code duplication: WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Peter Rybin <prybin> |
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | apavlov, buildbot, dglazkov, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, webkit.review.bot, yurys |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: | |||
|
Description
Peter Rybin
2013-03-25 08:46:35 PDT
Created attachment 194867 [details]
Patch
Comment on attachment 194867 [details] Patch Attachment 194867 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17246424 New failing tests: inspector/debugger/watch-expressions-panel-switch.html inspector/elements/event-listener-sidebar.html inspector/elements/event-listeners-about-blank.html Created attachment 194878 [details]
Archive of layout-test-results from gce-cr-linux-03 for chromium-linux-x86_64
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-03 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment on attachment 194867 [details] Patch Attachment 194867 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17211763 New failing tests: inspector/debugger/watch-expressions-panel-switch.html inspector/elements/event-listener-sidebar.html inspector/elements/event-listeners-about-blank.html Created attachment 194890 [details]
Archive of layout-test-results from gce-cr-linux-07 for chromium-linux-x86_64
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment on attachment 194867 [details] Patch Attachment 194867 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17313136 New failing tests: inspector/debugger/watch-expressions-panel-switch.html inspector/elements/event-listener-sidebar.html inspector/elements/event-listeners-about-blank.html Created attachment 194906 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Comment on attachment 194867 [details] Patch Attachment 194867 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17211800 New failing tests: inspector/debugger/watch-expressions-panel-switch.html inspector/elements/event-listener-sidebar.html inspector/elements/event-listeners-about-blank.html Created attachment 194909 [details]
Archive of layout-test-results from webkit-ews-04 for mac-future
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04 Port: mac-future Platform: Mac OS X 10.8.2
Created attachment 194932 [details]
Patch
Comment on attachment 194932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194932&action=review > Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:105 > for (var i = 0; i < this.extraProperties.length; ++i) style: please add {} for multiline if block. > Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:473 > +WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements = function(treeElement, properties, internalProperties, constructor, comparator, skipProto, value) { wrapPropertyAsElements -> populateWithProperties constructor -> treeElementConstructor Created attachment 195101 [details]
Patch
Comment on attachment 194932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194932&action=review >> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:105 >> for (var i = 0; i < this.extraProperties.length; ++i) > > style: please add {} for multiline if block. Done >> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:473 >> +WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements = function(treeElement, properties, internalProperties, constructor, comparator, skipProto, value) { > > wrapPropertyAsElements -> populateWithProperties > constructor -> treeElementConstructor Done Comment on attachment 195101 [details] Patch Clearing flags on attachment: 195101 Committed r146900: <http://trac.webkit.org/changeset/146900> All reviewed patches have been landed. Closing bug. |