| Summary: | Fix build when XSLT_SUPPORT is not defined | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Krzysztof Kowalczyk <kkowalczyk> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | 420+ | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.4 | ||||||||
| Attachments: |
|
||||||||
|
Description
Krzysztof Kowalczyk
2006-10-16 07:24:27 PDT
Created attachment 11110 [details]
fix build when XSLT_SUPPORT is not defined
* remove #define XSLT_SUPPORT from WebCore\config.h, because it defeats the purpose of having it configurable (should be passed from a Makefile)
* fix on place in XMLTokenizer that was using xslt support unconditionally
Comment on attachment 11110 [details]
fix build when XSLT_SUPPORT is not defined
If you're going to make this change to config.h, you'll need to change the build configurations on Mac (at least).
I can't do it since I have no access to Mac. I was hoping that a mac-owning commiter could do it. Created attachment 11123 [details]
fix unconditional use of XSLT
Updated the patch to not modify config.h. I would still like this change to be made but if submitting a change to xcode project files is a requirement for the patch, then unfortunately I can't do it because I don't have access to mac/xcode. For someone having an apple, it should be trivial.
|