Summary: | Web Inspector: OverviewGrid. Dragged window may change its width due to accumulating rounding error | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Ilya Tikhonovsky <loislo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Ilya Tikhonovsky
2013-03-23 09:51:03 PDT
Created attachment 194709 [details]
Patch
Comment on attachment 194709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194709&action=review > Source/WebCore/ChangeLog:8 > + The old version had problem with rounding because it recalculates the window size on each event. Why would this be a problem? > Source/WebCore/inspector/front-end/OverviewGrid.js:320 > + var delta = (event.pageX - this._dragStartPoint) / this._parentElement.clientWidth; I am not sure we need more complexity in this code. Created attachment 195025 [details]
Patch
(In reply to comment #2) > (From update of attachment 194709 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=194709&action=review > > > Source/WebCore/ChangeLog:8 > > + The old version had problem with rounding because it recalculates the window size on each event. > > Why would this be a problem? As we found in the offline discussion the rounding was the root of problem. > > > Source/WebCore/inspector/front-end/OverviewGrid.js:320 > > + var delta = (event.pageX - this._dragStartPoint) / this._parentElement.clientWidth; > > I am not sure we need more complexity in this code. I eliminated moveWindow code so the code became clear. Committed r146866: <http://trac.webkit.org/changeset/146866> |