Bug 113136

Summary: Web Inspector: Exception when turning on pretty print without any displayed source in the editor
Product: WebKit Reporter: PhistucK <phistuck>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Added an existence check.
none
Fixed the change log. none

PhistucK
Reported 2013-03-23 08:57:59 PDT
Clicking on the pretty print button throws a TypeError when no source is displayed within the Sources editor. This happens because we try to get the URL of the currently edited source when notifying the user metrics about turning on pretty print, without checking whether there actually is one.
Attachments
Added an existence check. (1.68 KB, patch)
2013-03-23 09:08 PDT, PhistucK 		no flags
DetailsFormatted DiffDiff
Fixed the change log. (1.70 KB, patch)
2013-03-23 09:12 PDT, PhistucK 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
PhistucK
Comment 1 2013-03-23 09:08:31 PDT
Created attachment 194704 [details] Added an existence check.
WebKit Review Bot
Comment 2 2013-03-23 09:11:45 PDT
Attachment 194704 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/inspector/front-end/ScriptsPanel.js']" exit_code: 1 Source/WebCore/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
PhistucK
Comment 3 2013-03-23 09:12:53 PDT
Created attachment 194706 [details] Fixed the change log.
WebKit Review Bot
Comment 4 2013-03-25 01:57:53 PDT
Comment on attachment 194706 [details] Fixed the change log. Clearing flags on attachment: 194706 Committed r146749: <http://trac.webkit.org/changeset/146749>
WebKit Review Bot
Comment 5 2013-03-25 01:57:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.