Bug 113080

Summary: Web Inspector: Flame Chart. Scroll dividers together with underlying chart.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Description Ilya Tikhonovsky 2013-03-22 10:13:48 PDT
patch to follow.
Comment 1 Ilya Tikhonovsky 2013-03-23 08:17:27 PDT
Created attachment 194703 [details]
Patch
Comment 2 Pavel Feldman 2013-03-25 01:05:24 PDT
Comment on attachment 194703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194703&action=review

> Source/WebCore/inspector/front-end/TimelineGrid.js:94
> +        if (calculator.grandMinimumBoundary)

Checking for function existence is not compiler friendly.

> Source/WebCore/inspector/front-end/TimelineGrid.js:132
> +                left = calculator.computePosition(calculator.minimumBoundary() + slice * i - sliceRemainder);

If you want dividers to be consistent with your canvas data, you should paint them on canvas. updateDividers is an expensive method.
Comment 3 Ilya Tikhonovsky 2013-03-26 02:36:24 PDT
Created attachment 195041 [details]
Patch
Comment 4 Pavel Feldman 2013-03-26 04:20:03 PDT
Comment on attachment 195041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195041&action=review

> Source/WebCore/ChangeLog:26
> +2013-03-22  Ilya Tikhonovsky  <loislo@chromium.org>

One of these is extra.

> Source/WebCore/inspector/front-end/TimelineGrid.js:235
> +    grandMinimumBoundary: function() { },

What if this is 0 at all times?
Comment 5 Ilya Tikhonovsky 2013-03-26 08:57:05 PDT
Committed r146890: <http://trac.webkit.org/changeset/146890>