Bug 113028

Summary:

Web Inspector: Correctly implement scrollToLine, revealLine and setSelection on CodeMirror editor.

Product:

WebKit

Reporter:

Vsevolod Vlasov <vsevik>

Component:

Web Inspector (Deprecated)

Assignee:

Vsevolod Vlasov <vsevik>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+

Vsevolod Vlasov

Reported 2013-03-22 02:33:51 PDT

Patch to follow

Attachments
Patch (8.29 KB, patch) 2013-03-22 02:42 PDT, Vsevolod Vlasov	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Vsevolod Vlasov

Comment 1 2013-03-22 02:42:43 PDT

Created attachment 194484 [details] Patch

Andrey Lushnikov

Comment 2 2013-03-22 03:15:47 PDT

Comment on attachment 194484 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194484&action=review > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:78 > + this._codeMirror.on("beforeSelectionChange", this._selectionChange.bind(this)); There's already a selection listener in ToT, but it observes "cursorActivity" event. > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:324 > + _coordsChar: function(coords) Maybe "coordsCharLocal"? > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:332 > + var middle = (begin + end) / 2; > + middle = middle >>> 0; maybe (begin + end) >> 1 ?

Vsevolod Vlasov

Comment 3 2013-03-22 08:25:19 PDT

Committed r146615: <http://trac.webkit.org/changeset/146615>

Note You need to log in before you can comment on or make changes to this bug.