Bug 113011
| Summary: | Please restore ValueCheck functionality in WebCore | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> |
| Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, benjamin, eric, mjs |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alexey Proskuryakov
Changes in bug 112831 yesterday disabled almost all ValueCheck security checks in WebCore. They need to be restored.
Please see Maciej's suggestion in bug 112873: "It sounds like it will be possible to fix the StringImpl/AtomicStringImpl cases once the new statically allocated StringImpl's return true from isStatic()."
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
Adam, Eric, who is going to work on this?
Adam Barth
(In reply to comment #1)
> Adam, Eric, who is going to work on this?
I don't plan to work on this issue this week.
Alexey Proskuryakov
Do you plan to work on this after this week?
Maciej Stachowiak
(In reply to comment #3)
> Do you plan to work on this after this week?
I think it's going to our job to deal with it now, given the recent announcement. Let's let our former colleagues go in peace.
Alexey Proskuryakov
I was thinking about this part of Eric's e-mail to webkit-dev: "Adam and I are happy to work with other reviewers to remove PLATFORM(CHROMIUM) code and other messes we may have caused over the years from webkit.org"
This is one of the most recent cases of "mess".
Adam Barth
I'm happy to roll out the patches that led to the changes to ValueCheck if that would be helpful to you. Completing this work requires landing the patch that makes HTMLNames thread safe. That patch works for Chromium today, but making it work for other ports is probably out of scope for helping with cleanup.