Bug 113008

Summary: Web Inspector: [Settings] Use registry to track settings objects.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Eugene Klyuchnikov
Reported 2013-03-21 23:18:03 PDT
Currently .createSetting creates new instance any time it is invoked. When one instance saves value, the other instance do not know about it. To resolve this issue we can use registry to make .createSetting return same object for specific key.
Attachments
Patch (4.12 KB, patch)
2013-03-21 23:21 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-03-21 23:21:15 PDT
Created attachment 194450 [details] Patch
WebKit Review Bot
Comment 2 2013-03-25 00:48:14 PDT
Comment on attachment 194450 [details] Patch Clearing flags on attachment: 194450 Committed r146745: <http://trac.webkit.org/changeset/146745>
WebKit Review Bot
Comment 3 2013-03-25 00:48:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.