Bug 112982

Summary: [CoordGfx] Support to share GraphicsSurface flags with client.
Product: WebKit Reporter: Kalyan <kalyan.kondapally>
Component: WebKit EFLAssignee: Kalyan <kalyan.kondapally>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, dino, lucas.de.marchi, luiz, noam, sergio, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 105659    
Attachments:
Description Flags
patch
none
patchv2
noam: review+
patchv3
none
patchv4
none
patchv5 none

Kalyan
Reported 2013-03-21 17:08:07 PDT
Add support to pass GraphicsSurface flags during it's client creation. This would be helpful to determine certain cases like disable blending in case alpha is not supported/disabled by GraphicsSurface.
Attachments
patch (6.71 KB, patch)
2013-03-21 18:31 PDT, Kalyan 		no flags
DetailsFormatted DiffDiff
patchv2 (6.75 KB, patch)
2013-03-25 12:24 PDT, Kalyan 		noam: review+
DetailsFormatted DiffDiff
patchv3 (6.71 KB, patch)
2013-03-26 11:35 PDT, Kalyan 		no flags
DetailsFormatted DiffDiff
patchv4 (15.12 KB, patch)
2013-03-26 15:32 PDT, Kalyan 		no flags
DetailsFormatted DiffDiff
patchv5 (9.67 KB, patch)
2013-03-26 16:00 PDT, Kalyan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Kalyan
Comment 1 2013-03-21 18:31:38 PDT
Created attachment 194410 [details] patch
Kalyan
Comment 2 2013-03-25 12:24:36 PDT
Created attachment 194901 [details] patchv2
Kalyan
Comment 3 2013-03-26 11:35:35 PDT
Created attachment 195126 [details] patchv3
Noam Rosenthal
Comment 4 2013-03-26 11:39:44 PDT
Comment on attachment 195126 [details] patchv3 LGTM. Switching back to r? since it needs a WK2 owner signoff.
Kalyan
Comment 5 2013-03-26 15:32:10 PDT
Created attachment 195175 [details] patchv4
Kalyan
Comment 6 2013-03-26 15:44:46 PDT
Comment on attachment 195175 [details] patchv4 Wrong patch, Marking the patch as obsolete. Will update with right one
Kalyan
Comment 7 2013-03-26 16:00:50 PDT
Created attachment 195177 [details] patchv5
Kalyan
Comment 8 2013-03-26 16:12:25 PDT
(In reply to comment #7) > Created an attachment (id=195177) [details] > patchv5 Included the needed changes in EFL PLatformLayer and GraphicsSurface to take the flags into use.
Benjamin Poulain
Comment 9 2013-03-26 16:26:23 PDT
Comment on attachment 195177 [details] patchv5 Signed off by me.
WebKit Review Bot
Comment 10 2013-03-27 00:11:02 PDT
Comment on attachment 195177 [details] patchv5 Clearing flags on attachment: 195177 Committed r146968: <http://trac.webkit.org/changeset/146968>
WebKit Review Bot
Comment 11 2013-03-27 00:11:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.