Bug 11294

Summary: Add getModifierState method to KeyboardEvent
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch
none
patch 2 mitz: review+

Sam Weinig
Reported 2006-10-14 14:04:04 PDT
The DOM3 events spec (http://www.w3.org/TR/2003/NOTE-DOM-Level-3-Events-20031107/events.html#Events-KeyboardEvent) includes a getModifierState method that currently we only implement in the Objective-C bindings. We should implement in KeyboardEvent instead so that it can be used for all the bindings.
Attachments
patch (4.58 KB, patch)
2006-10-14 15:34 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
patch 2 (4.54 KB, patch)
2006-10-15 14:25 PDT, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2006-10-14 15:34:09 PDT
Created attachment 11090 [details] patch Moves functionality down from Objective-C DOM file DOMEvents.mm to KeyboardEvent class.
Sam Weinig
Comment 2 2006-10-15 14:25:40 PDT
Created attachment 11100 [details] patch 2 Updated based on conversation with mitz in IRC.
mitz
Comment 3 2006-10-15 14:29:07 PDT
Comment on attachment 11100 [details] patch 2 r=me
Sam Weinig
Comment 4 2006-10-15 15:29:01 PDT
Landed in r17064.
Note You need to log in before you can comment on or make changes to this bug.