Bug 112877

Summary: Refactoring: Reorganize datetime field element parameters
Product: WebKit Reporter: Kunihiko Sakamoto <ksakamoto>
Component: FormsAssignee: Kunihiko Sakamoto <ksakamoto>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ojan.autocc, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch 2 none

Kunihiko Sakamoto
Reported 2013-03-20 22:42:04 PDT
Refactor parameters for datetime field element constructors.
Attachments
Patch (52.32 KB, patch)
2013-03-20 22:46 PDT, Kunihiko Sakamoto 		no flags
DetailsFormatted DiffDiff
Patch 2 (52.57 KB, patch)
2013-03-21 02:28 PDT, Kunihiko Sakamoto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kunihiko Sakamoto
Comment 1 2013-03-20 22:46:59 PDT
Created attachment 194185 [details] Patch
Kent Tamura
Comment 2 2013-03-21 01:57:24 PDT
Comment on attachment 194185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194185&action=review Almost ok > Source/WebCore/html/shadow/DateTimeEditElement.cpp:71 > + DateTimeNumericFieldElement::Step createStep(const Decimal& msPerFieldUnit, const Decimal& msPerFieldSize) const; Because almost all of real arguments for createStep are WTF::msPerFoo, we had better make the argument types double, and convert them to Decimal in createStep.
Kunihiko Sakamoto
Comment 3 2013-03-21 02:28:36 PDT
Created attachment 194207 [details] Patch 2
Kunihiko Sakamoto
Comment 4 2013-03-21 02:29:29 PDT
Comment on attachment 194185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194185&action=review >> Source/WebCore/html/shadow/DateTimeEditElement.cpp:71 >> + DateTimeNumericFieldElement::Step createStep(const Decimal& msPerFieldUnit, const Decimal& msPerFieldSize) const; > > Because almost all of real arguments for createStep are WTF::msPerFoo, we had better make the argument types double, and convert them to Decimal in createStep. Thanks for the suggestion. Done.
WebKit Review Bot
Comment 5 2013-03-21 04:57:14 PDT
Comment on attachment 194207 [details] Patch 2 Clearing flags on attachment: 194207 Committed r146453: <http://trac.webkit.org/changeset/146453>
WebKit Review Bot
Comment 6 2013-03-21 04:57:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.